patch-2.1.58 linux/net/sunrpc/pmap_clnt.c

• Lines: 24
• Date: Sun Oct 12 10:17:46 1997
• Orig file: v2.1.57/linux/net/sunrpc/pmap_clnt.c
• Orig date: Thu May 15 16:48:07 1997

diff -u --recursive --new-file v2.1.57/linux/net/sunrpc/pmap_clnt.c linux/net/sunrpc/pmap_clnt.c
@@ -54,15 +54,16 @@
 	}
 	clnt->cl_binding = 1;
 
-	task->tk_status = 0;
-	if (!(pmap_clnt = pmap_create(clnt->cl_server, sap, map->pm_prot))) {
-		task->tk_status = -EACCES;
+	task->tk_status = -EACCES; /* why set this? returns -EIO below */
+	if (!(pmap_clnt = pmap_create(clnt->cl_server, sap, map->pm_prot)))
 		goto bailout;
-	}
-	if (!(child = rpc_new_child(pmap_clnt, task))) {
-		rpc_destroy_client(pmap_clnt);
+	task->tk_status = 0;
+
+	/*
+	 * Note: rpc_new_child will release client after a failure.
+	 */
+	if (!(child = rpc_new_child(pmap_clnt, task)))
 		goto bailout;
-	}
 
 	/* Setup the call info struct */
 	rpc_call_setup(child, PMAP_GETPORT, map, &clnt->cl_port, 0);