patch-2.1.25 linux/drivers/net/sdla.c

Next file: linux/drivers/net/sdla_fr.c
Previous file: linux/drivers/net/scc.c
Back to the patch index
Back to the overall index

diff -u --recursive --new-file v2.1.24/linux/drivers/net/sdla.c linux/drivers/net/sdla.c
@@ -82,147 +82,145 @@
 
 static void sdla_read(struct device *dev, int addr, void *buf, short len)
 {
-   unsigned long flags;
-   char          *temp, *base;
-   int           offset, bytes;
-
-   temp = buf;
-   while(len)
-   {
-      offset = addr & SDLA_ADDR_MASK;
-      bytes = offset + len > SDLA_WINDOW_SIZE ? SDLA_WINDOW_SIZE - offset : len;
-      base = (void *) (dev->mem_start + offset);
-
-      save_flags(flags);
-      cli();
-      SDLA_WINDOW(dev, addr);
-      memcpy(temp, base, bytes);
-      restore_flags(flags);
-
-      addr += bytes;
-      temp += bytes;
-      len  -= bytes;
-   }  
+	unsigned long flags;
+	char          *temp, *base;
+	int           offset, bytes;
+
+	temp = buf;
+	while(len)
+	{	
+		offset = addr & SDLA_ADDR_MASK;
+		bytes = offset + len > SDLA_WINDOW_SIZE ? SDLA_WINDOW_SIZE - offset : len;
+		base = (void *) (dev->mem_start + offset);
+
+		save_flags(flags);
+		cli();
+		SDLA_WINDOW(dev, addr);
+		memcpy(temp, base, bytes);
+		restore_flags(flags);
+
+		addr += bytes;
+		temp += bytes;
+		len  -= bytes;
+	}  
 }
 
 static void sdla_write(struct device *dev, int addr, void *buf, short len)
 {
-   unsigned long flags;
-   char          *temp, *base;
-   int           offset, bytes;
-
-   temp = buf;
-   while(len)
-   {
-      offset = addr & SDLA_ADDR_MASK;
-      bytes = offset + len > SDLA_WINDOW_SIZE ? SDLA_WINDOW_SIZE - offset : len;
-      base = (void *) (dev->mem_start + offset);
-
-      save_flags(flags);
-      cli();
-      SDLA_WINDOW(dev, addr);
-      memcpy(base, temp, bytes);
-      restore_flags(flags);
-
-      addr += bytes;
-      temp += bytes;
-      len  -= bytes;
-   }
+	unsigned long flags;
+	char          *temp, *base;
+	int           offset, bytes;
+
+	temp = buf;
+	while(len)
+	{
+		offset = addr & SDLA_ADDR_MASK;
+		bytes = offset + len > SDLA_WINDOW_SIZE ? SDLA_WINDOW_SIZE - offset : len;
+		base = (void *) (dev->mem_start + offset);
+		save_flags(flags);
+		cli();
+		SDLA_WINDOW(dev, addr);
+		memcpy(base, temp, bytes);
+		restore_flags(flags);
+		addr += bytes;
+		temp += bytes;
+		len  -= bytes;
+	}
 }
 
 static void sdla_clear(struct device *dev)
 {
-   unsigned long flags;
-   char          *base;
-   int           len, addr, bytes;
-
-   len = 65536;
-   addr = 0;
-   bytes = SDLA_WINDOW_SIZE;
-   base = (void *) dev->mem_start;
-
-   save_flags(flags);
-   cli();
-   while(len)
-   {
-      SDLA_WINDOW(dev, addr);
-      memset(base, 0, bytes);
-
-      addr += bytes;
-      len  -= bytes;
-   }
-   restore_flags(flags);
+	unsigned long flags;
+	char          *base;
+	int           len, addr, bytes;
+
+	len = 65536;	
+	addr = 0;
+	bytes = SDLA_WINDOW_SIZE;
+	base = (void *) dev->mem_start;
+
+	save_flags(flags);
+	cli();
+	while(len)
+	{
+		SDLA_WINDOW(dev, addr);
+		memset(base, 0, bytes);
+
+		addr += bytes;
+		len  -= bytes;
+	}
+	restore_flags(flags);
 }
 
 static char sdla_byte(struct device *dev, int addr)
 {
-   unsigned long flags;
-   char          byte, *temp;
+	unsigned long flags;
+	char          byte, *temp;
 
-   temp = (void *) (dev->mem_start + (addr & SDLA_ADDR_MASK));
+	temp = (void *) (dev->mem_start + (addr & SDLA_ADDR_MASK));
 
-   save_flags(flags);
-   cli();
-   SDLA_WINDOW(dev, addr);
-   byte = *temp;
-   restore_flags(flags);
+	save_flags(flags);
+	cli();
+	SDLA_WINDOW(dev, addr);
+	byte = *temp;
+	restore_flags(flags);
 
-   return(byte);
+	return(byte);
 }
 
 void sdla_stop(struct device *dev)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
 
-   flp = dev->priv;
-   switch(flp->type)
-   {
-      case SDLA_S502A:
-         outb(SDLA_S502A_HALT, dev->base_addr + SDLA_REG_CONTROL);
-         flp->state = SDLA_HALT;
-         break;
-      case SDLA_S502E:
-         outb(SDLA_HALT, dev->base_addr + SDLA_REG_Z80_CONTROL);
-         outb(SDLA_S502E_ENABLE, dev->base_addr + SDLA_REG_CONTROL);
-         flp->state = SDLA_S502E_ENABLE;
-         break;
-      case SDLA_S507:
-         flp->state &= ~SDLA_CPUEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-      case SDLA_S508:
-         flp->state &= ~SDLA_CPUEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-   }
+	flp = dev->priv;
+	switch(flp->type)
+	{
+		case SDLA_S502A:
+			outb(SDLA_S502A_HALT, dev->base_addr + SDLA_REG_CONTROL);
+			flp->state = SDLA_HALT;
+			break;
+		case SDLA_S502E:
+			outb(SDLA_HALT, dev->base_addr + SDLA_REG_Z80_CONTROL);
+			outb(SDLA_S502E_ENABLE, dev->base_addr + SDLA_REG_CONTROL);
+			flp->state = SDLA_S502E_ENABLE;
+			break;
+		case SDLA_S507:
+			flp->state &= ~SDLA_CPUEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+		case SDLA_S508:
+			flp->state &= ~SDLA_CPUEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+	}
 }
 
 void sdla_start(struct device *dev)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
 
-   flp = dev->priv;
-   switch(flp->type)
-   {
-      case SDLA_S502A:
-         outb(SDLA_S502A_NMI, dev->base_addr + SDLA_REG_CONTROL);
-         outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
-         flp->state = SDLA_S502A_START;
-         break;
-      case SDLA_S502E:
-         outb(SDLA_S502E_CPUEN, dev->base_addr + SDLA_REG_Z80_CONTROL);
-         outb(0x00, dev->base_addr + SDLA_REG_CONTROL);
-         flp->state = 0;
-         break;
-      case SDLA_S507:
-         flp->state |= SDLA_CPUEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-      case SDLA_S508:
-         flp->state |= SDLA_CPUEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-   }
+	flp = dev->priv;
+	switch(flp->type)
+	{
+		case SDLA_S502A:
+			outb(SDLA_S502A_NMI, dev->base_addr + SDLA_REG_CONTROL);
+			outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
+			flp->state = SDLA_S502A_START;
+			break;
+		case SDLA_S502E:
+			outb(SDLA_S502E_CPUEN, dev->base_addr + SDLA_REG_Z80_CONTROL);
+			outb(0x00, dev->base_addr + SDLA_REG_CONTROL);
+			flp->state = 0;
+			break;
+		case SDLA_S507:
+			flp->state |= SDLA_CPUEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+		case SDLA_S508:
+			flp->state |= SDLA_CPUEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+	}
 }
 
 /****************************************************
@@ -237,26 +235,26 @@
 
 int sdla_z80_poll(struct device *dev, int z80_addr, int jiffs, char resp1, char resp2)
 {
-   unsigned long start, done, now;
-   char          resp, *temp;
+	unsigned long start, done, now;
+	char          resp, *temp;
 
-   start = now = jiffies;
-   done = jiffies + jiffs;
+	start = now = jiffies;
+	done = jiffies + jiffs;
 
-   temp = (void *)dev->mem_start;
-   temp += z80_addr & SDLA_ADDR_MASK;
-
-   resp = ~resp1;
-   while ((jiffies < done) && (resp != resp1) && (!resp2 || (resp != resp2)))
-   {
-      if (jiffies != now)
-      {
-         SDLA_WINDOW(dev, z80_addr);
-         now = jiffies;
-         resp = *temp;
-      }
-   }
-   return(jiffies < done ? jiffies - start : -1);
+	temp = (void *)dev->mem_start;
+	temp += z80_addr & SDLA_ADDR_MASK;
+	
+	resp = ~resp1;
+	while ((jiffies < done) && (resp != resp1) && (!resp2 || (resp != resp2)))
+	{
+		if (jiffies != now)
+		{
+			SDLA_WINDOW(dev, z80_addr);
+			now = jiffies;
+			resp = *temp;
+		}
+	}
+	return(jiffies < done ? jiffies - start : -1);
 }
 
 /* constants for Z80 CPU speed */
@@ -267,46 +265,45 @@
 
 static int sdla_cpuspeed(struct device *dev, struct ifreq *ifr)
 {
-   int  jiffs;
-   char data;
+	int  jiffs;
+	char data;
 
-   sdla_start(dev);
-   if (sdla_z80_poll(dev, 0, 3*HZ, Z80_READY, 0) < 0)
-      return(-EIO);
-
-   data = LOADER_READY;
-   sdla_write(dev, 0, &data, 1);
-
-   if ((jiffs = sdla_z80_poll(dev, 0, 8*HZ, Z80_SCC_OK, Z80_SCC_BAD)) < 0)
-      return(-EIO);
-
-   sdla_stop(dev);
-   sdla_read(dev, 0, &data, 1);
-
-   if (data == Z80_SCC_BAD)
-      return(-EIO);
-
-   if (data != Z80_SCC_OK)
-      return(-EINVAL);
-
-   if (jiffs < 165)
-      ifr->ifr_mtu = SDLA_CPU_16M;
-   else
-      if (jiffs < 220)
-         ifr->ifr_mtu = SDLA_CPU_10M;
-      else
-         if (jiffs < 258)
-            ifr->ifr_mtu = SDLA_CPU_8M;
-         else
-            if (jiffs < 357)
-               ifr->ifr_mtu = SDLA_CPU_7M;
-            else
-               if (jiffs < 467)
-                  ifr->ifr_mtu = SDLA_CPU_5M;
-               else
-                  ifr->ifr_mtu = SDLA_CPU_3M;
+	sdla_start(dev);
+	if (sdla_z80_poll(dev, 0, 3*HZ, Z80_READY, 0) < 0)
+		return(-EIO);
+
+	data = LOADER_READY;
+	sdla_write(dev, 0, &data, 1);
+
+	if ((jiffs = sdla_z80_poll(dev, 0, 8*HZ, Z80_SCC_OK, Z80_SCC_BAD)) < 0)
+		return(-EIO);
+
+	sdla_stop(dev);
+	sdla_read(dev, 0, &data, 1);
+
+	if (data == Z80_SCC_BAD)
+	{
+		printk("%s: SCC bad\n", dev->name);
+		return(-EIO);
+	}
+
+	if (data != Z80_SCC_OK)
+		return(-EINVAL);
+
+	if (jiffs < 165)
+		ifr->ifr_mtu = SDLA_CPU_16M;
+	else if (jiffs < 220)
+		ifr->ifr_mtu = SDLA_CPU_10M;
+	else if (jiffs < 258)
+		ifr->ifr_mtu = SDLA_CPU_8M;
+	else if (jiffs < 357)
+		ifr->ifr_mtu = SDLA_CPU_7M;
+	else if (jiffs < 467)
+		ifr->ifr_mtu = SDLA_CPU_5M;
+	else
+		ifr->ifr_mtu = SDLA_CPU_3M;
  
-   return(0);
+	return(0);
 }
 
 /************************************************
@@ -316,175 +313,174 @@
  *
  ************************************************/
 
-struct _dlci_stat {
-   short dlci		__attribute__((packed));
-   char  flags		__attribute__((packed));
+struct _dlci_stat 
+{
+	short dlci		__attribute__((packed));
+	char  flags		__attribute__((packed));
 };
 
-struct _frad_stat {
-   char    flags;
-   struct _dlci_stat dlcis[SDLA_MAX_DLCI];
+struct _frad_stat 
+{
+	char    flags;
+	struct _dlci_stat dlcis[SDLA_MAX_DLCI];
 };
 
 static void sdla_errors(struct device *dev, int cmd, int dlci, int ret, int len, void *data) 
 {
-   struct _dlci_stat *pstatus;
-   short             *pdlci;
-   int               i;
-   char              *state, line[30];
-
-   switch (ret)
-   {
-      case SDLA_RET_MODEM:
-         state = data;
-         if (*state & SDLA_MODEM_DCD_LOW)
-            printk(KERN_INFO "%s: Modem DCD unexpectedly low!\n", dev->name);
-         if (*state & SDLA_MODEM_CTS_LOW)
-            printk(KERN_INFO "%s: Modem CTS unexpectedly low!\n", dev->name);
-/* I should probably do something about this! */
-         break;
-
-      case SDLA_RET_CHANNEL_OFF:
-         printk(KERN_INFO "%s: Channel became inoperative!\n", dev->name);
-/* same here */
-         break;
-
-      case SDLA_RET_CHANNEL_ON:
-         printk(KERN_INFO "%s: Channel became operative!\n", dev->name);
-/* same here */
-         break;
-
-      case SDLA_RET_DLCI_STATUS:
-         printk(KERN_INFO "%s: Status change reported by Access Node.\n", dev->name);
-         len /= sizeof(struct _dlci_stat);
-         for(pstatus = data, i=0;i < len;i++,pstatus++)
-         {
-            if (pstatus->flags & SDLA_DLCI_NEW)
-               state = "new";
-            else
-               if (pstatus->flags & SDLA_DLCI_DELETED)
-                  state = "deleted";
-               else
-                  if (pstatus->flags & SDLA_DLCI_ACTIVE)
-                     state = "active";
-                  else
-                  {
-                     sprintf(line, "unknown status: %02X", pstatus->flags);
-                     state = line;
-                  }
-            printk(KERN_INFO "%s: DLCI %i: %s.\n", dev->name, pstatus->dlci, state);
-/* same here */
-         }
-         break;
-
-      case SDLA_RET_DLCI_UNKNOWN:
-         printk(KERN_INFO "%s: Received unknown DLCIs:", dev->name);
-         len /= sizeof(short);
-         for(pdlci = data,i=0;i < len;i++,pdlci++)
-            printk(" %i", *pdlci);
-         printk("\n");
-         break;
-
-      case SDLA_RET_TIMEOUT:
-         printk(KERN_ERR "%s: Command timed out!\n", dev->name);
-         break;
-
-      case SDLA_RET_BUF_OVERSIZE:
-         printk(KERN_INFO "%s: Bc/CIR overflow, acceptable size is %i\n", dev->name, len);
-         break;
-
-      case SDLA_RET_BUF_TOO_BIG:
-         printk(KERN_INFO "%s: Buffer size over specified max of %i\n", dev->name, len);
-         break;
-
-      case SDLA_RET_CHANNEL_INACTIVE:
-      case SDLA_RET_DLCI_INACTIVE:
-      case SDLA_RET_CIR_OVERFLOW:
-      case SDLA_RET_NO_BUFS:
-         if (cmd == SDLA_INFORMATION_WRITE)
-            break;
-
-      default: 
-         printk(KERN_DEBUG "%s: Cmd 0x%2.2X generated return code 0x%2.2X\n", dev->name, cmd, ret);
-/* Further processing could be done here */
-         break;
-   }
+	struct _dlci_stat *pstatus;
+	short             *pdlci;
+	int               i;
+	char              *state, line[30];
+
+	switch (ret)
+	{
+		case SDLA_RET_MODEM:
+			state = data;
+			if (*state & SDLA_MODEM_DCD_LOW)
+				printk(KERN_INFO "%s: Modem DCD unexpectedly low!\n", dev->name);
+			if (*state & SDLA_MODEM_CTS_LOW)
+				printk(KERN_INFO "%s: Modem CTS unexpectedly low!\n", dev->name);
+			/* I should probably do something about this! */
+			break;
+
+		case SDLA_RET_CHANNEL_OFF:
+			printk(KERN_INFO "%s: Channel became inoperative!\n", dev->name);
+			/* same here */
+			break;
+
+		case SDLA_RET_CHANNEL_ON:
+			printk(KERN_INFO "%s: Channel became operative!\n", dev->name);
+			/* same here */
+			break;
+
+		case SDLA_RET_DLCI_STATUS:
+			printk(KERN_INFO "%s: Status change reported by Access Node.\n", dev->name);
+			len /= sizeof(struct _dlci_stat);
+			for(pstatus = data, i=0;i < len;i++,pstatus++)
+			{
+				if (pstatus->flags & SDLA_DLCI_NEW)
+					state = "new";
+				else if (pstatus->flags & SDLA_DLCI_DELETED)
+					state = "deleted";
+				else if (pstatus->flags & SDLA_DLCI_ACTIVE)
+					state = "active";
+				else
+				{
+					sprintf(line, "unknown status: %02X", pstatus->flags);
+					state = line;
+				}
+				printk(KERN_INFO "%s: DLCI %i: %s.\n", dev->name, pstatus->dlci, state);
+				/* same here */
+			}
+			break;
+
+		case SDLA_RET_DLCI_UNKNOWN:
+			printk(KERN_INFO "%s: Received unknown DLCIs:", dev->name);
+			len /= sizeof(short);
+			for(pdlci = data,i=0;i < len;i++,pdlci++)
+				printk(" %i", *pdlci);
+			printk("\n");
+			break;
+
+		case SDLA_RET_TIMEOUT:
+			printk(KERN_ERR "%s: Command timed out!\n", dev->name);
+			break;
+
+		case SDLA_RET_BUF_OVERSIZE:
+			printk(KERN_INFO "%s: Bc/CIR overflow, acceptable size is %i\n", dev->name, len);
+			break;
+
+		case SDLA_RET_BUF_TOO_BIG:
+			printk(KERN_INFO "%s: Buffer size over specified max of %i\n", dev->name, len);
+			break;
+
+		case SDLA_RET_CHANNEL_INACTIVE:
+		case SDLA_RET_DLCI_INACTIVE:
+		case SDLA_RET_CIR_OVERFLOW:
+		case SDLA_RET_NO_BUFS:
+			if (cmd == SDLA_INFORMATION_WRITE)
+				break;
+
+		default: 
+			printk(KERN_DEBUG "%s: Cmd 0x%2.2X generated return code 0x%2.2X\n", dev->name, cmd, ret);
+			/* Further processing could be done here */
+			break;
+	}
 }
 
 static int sdla_cmd(struct device *dev, int cmd, short dlci, short flags, 
                         void *inbuf, short inlen, void *outbuf, short *outlen)
 {
-   static struct _frad_stat status;
-   struct frad_local        *flp;
-   struct sdla_cmd          *cmd_buf;
-   unsigned long            pflags;
-   int                      jiffs, ret, waiting, len;
-   long                     window;
-
-   flp = dev->priv;
-
-   window = flp->type == SDLA_S508 ? SDLA_508_CMD_BUF : SDLA_502_CMD_BUF;
-   cmd_buf = (struct sdla_cmd *)(dev->mem_start + (window & SDLA_ADDR_MASK));
-   ret = 0;
-   len = 0;
-   jiffs = jiffies + HZ;  /* 1 second is plenty */
-   save_flags(pflags);
-   cli();
-   SDLA_WINDOW(dev, window);
-   cmd_buf->cmd = cmd;
-   cmd_buf->dlci = dlci;
-   cmd_buf->flags = flags;
-
-   if (inbuf)
-      memcpy(cmd_buf->data, inbuf, inlen);
-
-   cmd_buf->length = inlen;
-
-   cmd_buf->opp_flag = 1;
-   restore_flags(pflags);
-
-   waiting = 1;
-   len = 0;
-   while (waiting && (jiffies <= jiffs))
-   {
-      if (waiting++ % 3) 
-      {
-         save_flags(pflags);
-         cli();
-         SDLA_WINDOW(dev, window);
-         waiting = ((volatile)(cmd_buf->opp_flag));
-         restore_flags(pflags);
-      }
-   }
-   
-   if (!waiting)
-   {
-      save_flags(pflags);
-      cli();
-      SDLA_WINDOW(dev, window);
-      ret = cmd_buf->retval;
-      len = cmd_buf->length;
-      if (outbuf && outlen)
-      {
-         *outlen = *outlen >= len ? len : *outlen;
-
-         if (*outlen)
-            memcpy(outbuf, cmd_buf->data, *outlen);
-      }
-
-      /* This is a local copy that's used for error handling */
-      if (ret)
-         memcpy(&status, cmd_buf->data, len > sizeof(status) ? sizeof(status) : len);
-
-      restore_flags(pflags);
-   }
-   else
-      ret = SDLA_RET_TIMEOUT;
+	static struct _frad_stat status;
+	struct frad_local        *flp;
+	struct sdla_cmd          *cmd_buf;
+	unsigned long            pflags;
+	int                      jiffs, ret, waiting, len;
+	long                     window;
+
+	flp = dev->priv;
+	window = flp->type == SDLA_S508 ? SDLA_508_CMD_BUF : SDLA_502_CMD_BUF;
+	cmd_buf = (struct sdla_cmd *)(dev->mem_start + (window & SDLA_ADDR_MASK));
+	ret = 0;
+	len = 0;
+	jiffs = jiffies + HZ;  /* 1 second is plenty */
+	save_flags(pflags);
+	cli();
+	SDLA_WINDOW(dev, window);
+	cmd_buf->cmd = cmd;
+	cmd_buf->dlci = dlci;
+	cmd_buf->flags = flags;
+
+	if (inbuf)
+		amemcpy(cmd_buf->data, inbuf, inlen);
+
+	cmd_buf->length = inlen;
+
+	cmd_buf->opp_flag = 1;
+	restore_flags(pflags);
+
+	waiting = 1;
+	len = 0;
+	while (waiting && (jiffies <= jiffs))
+	{
+		if (waiting++ % 3) 
+		{
+			save_flags(pflags);
+			cli();
+			SDLA_WINDOW(dev, window);
+			waiting = ((volatile)(cmd_buf->opp_flag));
+			restore_flags(pflags);
+		}
+	}
+	
+	if (!waiting)
+	{
+		save_flags(pflags);
+		cli();
+		SDLA_WINDOW(dev, window);
+		ret = cmd_buf->retval;
+		len = cmd_buf->length;
+		if (outbuf && outlen)
+		{
+			*outlen = *outlen >= len ? len : *outlen;
+
+			if (*outlen)
+				memcpy(outbuf, cmd_buf->data, *outlen);
+		}
+
+		/* This is a local copy that's used for error handling */
+		if (ret)
+			memcpy(&status, cmd_buf->data, len > sizeof(status) ? sizeof(status) : len);
+
+		restore_flags(pflags);
+	}
+	else
+		ret = SDLA_RET_TIMEOUT;
 
-   if (ret != SDLA_RET_OK)
-      sdla_errors(dev, cmd, dlci, ret, len, &status);
+	if (ret != SDLA_RET_OK)
+	   	sdla_errors(dev, cmd, dlci, ret, len, &status);
 
-   return(ret);
+	return(ret);
 }
 
 /***********************************************
@@ -497,141 +493,141 @@
 
 int sdla_activate(struct device *slave, struct device *master)
 {
-   struct frad_local *flp;
-   int               i;
+	struct frad_local *flp;
+	int i;
 
-   flp = slave->priv;
+	flp = slave->priv;
 
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->master[i] == master)
-         break;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->master[i] == master)
+			break;
 
-   if (i == CONFIG_DLCI_MAX)
-      return(-ENODEV);
+	if (i == CONFIG_DLCI_MAX)
+		return(-ENODEV);
 
-   flp->dlci[i] = abs(flp->dlci[i]);
+	flp->dlci[i] = abs(flp->dlci[i]);
 
-   if (slave->start && (flp->config.station == FRAD_STATION_NODE))
-      sdla_cmd(slave, SDLA_ACTIVATE_DLCI, 0, 0, &flp->dlci[i], sizeof(short), NULL, NULL);
+	if (slave->start && (flp->config.station == FRAD_STATION_NODE))
+		sdla_cmd(slave, SDLA_ACTIVATE_DLCI, 0, 0, &flp->dlci[i], sizeof(short), NULL, NULL);
 
-   return(0);
+	return(0);
 }
 
 int sdla_deactivate(struct device *slave, struct device *master)
 {
-   struct frad_local *flp;
-   int               i;
+	struct frad_local *flp;
+	int               i;
 
-   flp = slave->priv;
+	flp = slave->priv;
 
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->master[i] == master)
-         break;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->master[i] == master)
+			break;
 
-   if (i == CONFIG_DLCI_MAX)
-      return(-ENODEV);
+	if (i == CONFIG_DLCI_MAX)
+		return(-ENODEV);
 
-   flp->dlci[i] = -abs(flp->dlci[i]);
+	flp->dlci[i] = -abs(flp->dlci[i]);
 
-   if (slave->start && (flp->config.station == FRAD_STATION_NODE))
-      sdla_cmd(slave, SDLA_DEACTIVATE_DLCI, 0, 0, &flp->dlci[i], sizeof(short), NULL, NULL);
+	if (slave->start && (flp->config.station == FRAD_STATION_NODE))
+		sdla_cmd(slave, SDLA_DEACTIVATE_DLCI, 0, 0, &flp->dlci[i], sizeof(short), NULL, NULL);
 
-   return(0);
+	return(0);
 }
 
 int sdla_assoc(struct device *slave, struct device *master)
 {
-   struct frad_local *flp;
-   int               i;
+	struct frad_local *flp;
+	int               i;
 
-   if (master->type != ARPHRD_DLCI)
-      return(-EINVAL);
+	if (master->type != ARPHRD_DLCI)
+		return(-EINVAL);
 
-   flp = slave->priv;
+	flp = slave->priv;
 
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-   {
-      if (!flp->master[i])
-         break;
-      if (abs(flp->dlci[i]) == *(short *)(master->dev_addr))
-         return(-EADDRINUSE);
-   } 
-
-   if (i == CONFIG_DLCI_MAX)
-      return(-EMLINK);  /* #### Alan: Comments on this ?? */
-
-   MOD_INC_USE_COUNT;
-
-   flp->master[i] = master;
-   flp->dlci[i] = -*(short *)(master->dev_addr);
-   master->mtu = slave->mtu;
-
-   if (slave->start)
-      if (flp->config.station == FRAD_STATION_CPE)
-         sdla_reconfig(slave);
-      else
-         sdla_cmd(slave, SDLA_ADD_DLCI, 0, 0, master->dev_addr, sizeof(short), NULL, NULL);
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+	{
+		if (!flp->master[i])
+			break;
+		if (abs(flp->dlci[i]) == *(short *)(master->dev_addr))
+			return(-EADDRINUSE);
+	} 
+
+	if (i == CONFIG_DLCI_MAX)
+		return(-EMLINK);  /* #### Alan: Comments on this ?? */
+
+	MOD_INC_USE_COUNT;
+
+	flp->master[i] = master;
+	flp->dlci[i] = -*(short *)(master->dev_addr);
+	master->mtu = slave->mtu;
+
+	if (slave->start)
+		if (flp->config.station == FRAD_STATION_CPE)
+			sdla_reconfig(slave);
+		else
+			sdla_cmd(slave, SDLA_ADD_DLCI, 0, 0, master->dev_addr, sizeof(short), NULL, NULL);
 
-   return(0);
+	return(0);
 }
 
 int sdla_deassoc(struct device *slave, struct device *master)
 {
-   struct frad_local *flp;
-   int               i;
+	struct frad_local *flp;
+	int               i;
 
-   flp = slave->priv;
+	flp = slave->priv;
 
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->master[i] == master)
-         break;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->master[i] == master)
+			break;
 
-   if (i == CONFIG_DLCI_MAX)
-      return(-ENODEV);
+	if (i == CONFIG_DLCI_MAX)
+		return(-ENODEV);
 
-   flp->master[i] = NULL;
-   flp->dlci[i] = 0;
+	flp->master[i] = NULL;
+	flp->dlci[i] = 0;
 
-   MOD_DEC_USE_COUNT;
+	MOD_DEC_USE_COUNT;
 
-   if (slave->start)
-      if (flp->config.station == FRAD_STATION_CPE)
-         sdla_reconfig(slave);
-      else
-         sdla_cmd(slave, SDLA_DELETE_DLCI, 0, 0, master->dev_addr, sizeof(short), NULL, NULL);
+	if (slave->start)
+		if (flp->config.station == FRAD_STATION_CPE)
+			sdla_reconfig(slave);
+		else
+			sdla_cmd(slave, SDLA_DELETE_DLCI, 0, 0, master->dev_addr, sizeof(short), NULL, NULL);
 
-   return(0);
+	return(0);
 }
 
 int sdla_dlci_conf(struct device *slave, struct device *master, int get)
 {
-   struct frad_local *flp;
-   struct dlci_local *dlp;
-   int               i;
-   short             len, ret;
-
-   flp = slave->priv;
-
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->master[i] == master)
-         break;
-
-   if (i == CONFIG_DLCI_MAX)
-      return(-ENODEV);
-
-   dlp = master->priv;
-
-   ret = SDLA_RET_OK;
-   len = sizeof(struct dlci_conf);
-   if (slave->start)
-      if (get)
-         ret = sdla_cmd(slave, SDLA_READ_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0,  
-                     NULL, 0, &dlp->config, &len);
-      else
-         ret = sdla_cmd(slave, SDLA_SET_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0,  
-                     &dlp->config, sizeof(struct dlci_conf) - 4 * sizeof(short), NULL, NULL);
+	struct frad_local *flp;
+	struct dlci_local *dlp;
+	int               i;
+	short             len, ret;
+
+	flp = slave->priv;
+
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->master[i] == master)
+			break;
+
+	if (i == CONFIG_DLCI_MAX)
+		return(-ENODEV);
+
+	dlp = master->priv;
+
+	ret = SDLA_RET_OK;
+	len = sizeof(struct dlci_conf);
+	if (slave->start)
+		if (get)
+			ret = sdla_cmd(slave, SDLA_READ_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0,  
+			            NULL, 0, &dlp->config, &len);
+		else
+			ret = sdla_cmd(slave, SDLA_SET_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0,  
+			            &dlp->config, sizeof(struct dlci_conf) - 4 * sizeof(short), NULL, NULL);
 
-   return(ret == SDLA_RET_OK ? 0 : -EIO);
+	return(ret == SDLA_RET_OK ? 0 : -EIO);
 }
 
 /**************************
@@ -643,656 +639,643 @@
 /* NOTE: the DLCI driver deals with freeing the SKB!! */
 static int sdla_transmit(struct sk_buff *skb, struct device *dev)
 {
-   struct frad_local *flp;
-   int               ret, addr, accept;
-   short             size;
-   unsigned long     flags;
-   struct buf_entry  *pbuf;
-
-   flp = dev->priv;
-   ret = 0;
-   accept = 1;
-
-   if (dev->tbusy) 
-      return(1);
-
-   if (skb == NULL) 
-      return(0);
-
-   if (set_bit(0, (void*)&dev->tbusy) != 0)
-      printk(KERN_WARNING "%s: transmitter access conflict.\n", dev->name);
-   else
-   {
-      /*
-       * stupid GateD insists on setting up the multicast router thru us
-       * and we're ill equipped to handle a non Frame Relay packet at this
-       * time!
-       */
-
-      accept = 1;
-      switch (dev->type)
-      {
-         case ARPHRD_FRAD:
-            if (skb->dev->type != ARPHRD_DLCI)
-            {
-               printk(KERN_WARNING "%s: Non DLCI device, type %i, tried to send on FRAD module.\n", dev->name, skb->dev->type);
-               accept = 0;
-            }
-            break;
-
-         default:
-            printk(KERN_WARNING "%s: unknown firmware type 0x%4.4X\n", dev->name, dev->type);
-            accept = 0;
-            break;
-      }
-
-      if (accept)
-      {
-         /* this is frame specific, but till there's a PPP module, it's the default */
-         switch (flp->type)
-         {
-            case SDLA_S502A:
-            case SDLA_S502E:
-               ret = sdla_cmd(dev, SDLA_INFORMATION_WRITE, *(short *)(skb->dev->dev_addr), 0, skb->data, skb->len, NULL, NULL);
-               break;
-
-            case SDLA_S508:
-               size = sizeof(addr);
-               ret = sdla_cmd(dev, SDLA_INFORMATION_WRITE, *(short *)(skb->dev->dev_addr), 0, NULL, skb->len, &addr, &size);
-               if (ret == SDLA_RET_OK)
-               {
-                  save_flags(flags); 
-                  cli();
-                  SDLA_WINDOW(dev, addr);
-                  pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
-
-                  sdla_write(dev, pbuf->buf_addr, skb->data, skb->len);
-
-                  SDLA_WINDOW(dev, addr);
-                  pbuf->opp_flag = 1;
-                  restore_flags(flags);
-               }
-               break;
-         }
-
-         switch (ret)
-         {
-            case SDLA_RET_OK:
-               flp->stats.tx_packets++;
-               ret = DLCI_RET_OK;
-               break;
-
-            case SDLA_RET_CIR_OVERFLOW:
-            case SDLA_RET_BUF_OVERSIZE:
-            case SDLA_RET_NO_BUFS:
-               flp->stats.tx_dropped++;
-               ret = DLCI_RET_DROP;
-               break;
-
-            default:
-               flp->stats.tx_errors++;
-               ret = DLCI_RET_ERR;
-               break;
-         }
-      }
-      dev->tbusy = 0;
-   }
-   return(ret);
+	struct frad_local *flp;
+	int               ret, addr, accept;
+	short             size;
+	unsigned long     flags;
+	struct buf_entry  *pbuf;
+
+	flp = dev->priv;
+	ret = 0;
+	accept = 1;
+
+	if (dev->tbusy) 
+		return(1);
+
+	if (skb == NULL) 
+		return(0);
+
+	if (set_bit(0, (void*)&dev->tbusy) != 0)
+		printk(KERN_WARNING "%s: transmitter access conflict.\n", dev->name);
+	else
+	{
+		/*
+		 * stupid GateD insists on setting up the multicast router thru us
+		 * and we're ill equipped to handle a non Frame Relay packet at this
+		 * time!
+		 */
+
+		accept = 1;
+		switch (dev->type)
+		{
+			case ARPHRD_FRAD:
+				if (skb->dev->type != ARPHRD_DLCI)
+				{
+					printk(KERN_WARNING "%s: Non DLCI device, type %i, tried to send on FRAD module.\n", dev->name, skb->dev->type);
+					accept = 0;
+				}
+				break;
+
+			default:
+				printk(KERN_WARNING "%s: unknown firmware type 0x%4.4X\n", dev->name, dev->type);
+				accept = 0;
+				break;
+		}
+
+		if (accept)
+		{
+			/* this is frame specific, but till there's a PPP module, it's the default */
+			switch (flp->type)
+			{
+				case SDLA_S502A:
+				case SDLA_S502E:
+					ret = sdla_cmd(dev, SDLA_INFORMATION_WRITE, *(short *)(skb->dev->dev_addr), 0, skb->data, skb->len, NULL, NULL);
+					break;
+
+				case SDLA_S508:
+					size = sizeof(addr);
+					ret = sdla_cmd(dev, SDLA_INFORMATION_WRITE, *(short *)(skb->dev->dev_addr), 0, NULL, skb->len, &addr, &size);
+					if (ret == SDLA_RET_OK)
+					{
+						save_flags(flags); 
+						cli();
+						SDLA_WINDOW(dev, addr);
+						pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
+
+						sdla_write(dev, pbuf->buf_addr, skb->data, skb->len);
+
+						SDLA_WINDOW(dev, addr);
+						pbuf->opp_flag = 1;
+						restore_flags(flags);
+					}
+					break;
+			}
+
+			switch (ret)
+			{
+				case SDLA_RET_OK:
+					flp->stats.tx_packets++;
+					ret = DLCI_RET_OK;
+					break;
+
+				case SDLA_RET_CIR_OVERFLOW:
+				case SDLA_RET_BUF_OVERSIZE:
+				case SDLA_RET_NO_BUFS:
+					flp->stats.tx_dropped++;
+					ret = DLCI_RET_DROP;
+					break;
+
+				default:
+					flp->stats.tx_errors++;
+					ret = DLCI_RET_ERR;
+					break;
+			}
+		}
+		dev->tbusy = 0;
+	}
+	return(ret);
 }
 
 static void sdla_receive(struct device *dev)
 {
-   struct device     *master;
-   struct frad_local *flp;
-   struct dlci_local *dlp;
-   struct sk_buff    *skb;
-
-   struct sdla_cmd   *cmd;
-   struct buf_info   *pbufi;
-   struct buf_entry  *pbuf;
-
-   unsigned long     flags;
-   int               i, received, success, addr, buf_base, buf_top;
-   short             dlci, len, len2, split;
-
-   flp = dev->priv;
-   success = 1;
-   received = addr = buf_top = buf_base = 0;
-   len = dlci = 0;
-   skb = NULL;
-   master = NULL;
-   cmd = NULL;
-   pbufi = NULL;
-   pbuf = NULL;
-
-   save_flags(flags);
-   cli();
-
-   switch (flp->type)
-   {
-      case SDLA_S502A:
-      case SDLA_S502E:
-         cmd = (void *) (dev->mem_start + (SDLA_502_RCV_BUF & SDLA_ADDR_MASK));
-         SDLA_WINDOW(dev, SDLA_502_RCV_BUF);
-         success = cmd->opp_flag;
-         if (!success)
-            break;
-
-         dlci = cmd->dlci;
-         len = cmd->length;
-         break;
-
-      case SDLA_S508:
-         pbufi = (void *) (dev->mem_start + (SDLA_508_RXBUF_INFO & SDLA_ADDR_MASK));
-         SDLA_WINDOW(dev, SDLA_508_RXBUF_INFO);
-         pbuf = (void *) (dev->mem_start + ((pbufi->rse_base + flp->buffer * sizeof(struct buf_entry)) & SDLA_ADDR_MASK));
-         success = pbuf->opp_flag;
-         if (!success)
-            break;
-
-         buf_top = pbufi->buf_top;
-         buf_base = pbufi->buf_base;
-         dlci = pbuf->dlci;
-         len = pbuf->length;
-         addr = pbuf->buf_addr;
-         break;
-   }
-
-   /* common code, find the DLCI and get the SKB */
-   if (success)
-   {
-      for (i=0;i<CONFIG_DLCI_MAX;i++)
-         if (flp->dlci[i] == dlci)
-            break;
-
-      if (i == CONFIG_DLCI_MAX)
-      {
-         printk(KERN_NOTICE "%s: Received packet from invalid DLCI %i, ignoring.", dev->name, dlci);
-         flp->stats.rx_errors++;
-         success = 0;
-      }
-   }
-
-   if (success)
-   {
-      master = flp->master[i];
-      skb = dev_alloc_skb(len + sizeof(struct frhdr));
-      if (skb == NULL) 
-      {
-         printk(KERN_NOTICE "%s: Memory squeeze, dropping packet.\n", dev->name);
-         flp->stats.rx_dropped++; 
-         success = 0;
-      }
-      else
-         skb_reserve(skb, sizeof(struct frhdr));
-   }
-
-   /* pick up the data */
-   switch (flp->type)
-   {
-      case SDLA_S502A:
-      case SDLA_S502E:
-         if (success)
-            sdla_read(dev, SDLA_502_RCV_BUF + SDLA_502_DATA_OFS, skb_put(skb,len), len);
-
-         SDLA_WINDOW(dev, SDLA_502_RCV_BUF);
-         cmd->opp_flag = 0;
-         break;
-
-      case SDLA_S508:
-         if (success)
-         {
-            /* is this buffer split off the end of the internal ring buffer */
-            split = addr + len > buf_top + 1 ? len - (buf_top - addr + 1) : 0;
-            len2 = len - split;
-
-            sdla_read(dev, addr, skb_put(skb, len2), len2);
-            if (split)
-               sdla_read(dev, buf_base, skb_put(skb, split), split);
-         }
-
-         /* increment the buffer we're looking at */
-         SDLA_WINDOW(dev, SDLA_508_RXBUF_INFO);
-         flp->buffer = (flp->buffer + 1) % pbufi->rse_num;
-         pbuf->opp_flag = 0;
-         break;
-   }
-
-   if (success)
-   {
-      flp->stats.rx_packets++;
-      dlp = master->priv;
-      (*dlp->receive)(skb, master);
-   }
+	struct device	  *master;
+	struct frad_local *flp;
+	struct dlci_local *dlp;
+	struct sk_buff	 *skb;
+
+	struct sdla_cmd	*cmd;
+	struct buf_info	*pbufi;
+	struct buf_entry  *pbuf;
+
+	unsigned long	  flags;
+	int               i, received, success, addr, buf_base, buf_top;
+	short             dlci, len, len2, split;
+
+	flp = dev->priv;
+	success = 1;
+	received = addr = buf_top = buf_base = 0;
+	len = dlci = 0;
+	skb = NULL;
+	master = NULL;
+	cmd = NULL;
+	pbufi = NULL;
+	pbuf = NULL;
+
+	save_flags(flags);
+	cli();
+
+	switch (flp->type)
+	{
+		case SDLA_S502A:
+		case SDLA_S502E:
+			cmd = (void *) (dev->mem_start + (SDLA_502_RCV_BUF & SDLA_ADDR_MASK));
+			SDLA_WINDOW(dev, SDLA_502_RCV_BUF);
+			success = cmd->opp_flag;
+			if (!success)
+				break;
+
+			dlci = cmd->dlci;
+			len = cmd->length;
+			break;
+
+		case SDLA_S508:
+			pbufi = (void *) (dev->mem_start + (SDLA_508_RXBUF_INFO & SDLA_ADDR_MASK));
+			SDLA_WINDOW(dev, SDLA_508_RXBUF_INFO);
+			pbuf = (void *) (dev->mem_start + ((pbufi->rse_base + flp->buffer * sizeof(struct buf_entry)) & SDLA_ADDR_MASK));
+			success = pbuf->opp_flag;
+			if (!success)
+				break;
+
+			buf_top = pbufi->buf_top;
+			buf_base = pbufi->buf_base;
+			dlci = pbuf->dlci;
+			len = pbuf->length;
+			addr = pbuf->buf_addr;
+			break;
+	}
+
+	/* common code, find the DLCI and get the SKB */
+	if (success)
+	{
+		for (i=0;i<CONFIG_DLCI_MAX;i++)
+			if (flp->dlci[i] == dlci)
+				break;
+
+		if (i == CONFIG_DLCI_MAX)
+		{
+			printk(KERN_NOTICE "%s: Received packet from invalid DLCI %i, ignoring.", dev->name, dlci);
+			flp->stats.rx_errors++;
+			success = 0;
+		}
+	}
+
+	if (success)
+	{
+		master = flp->master[i];
+		skb = dev_alloc_skb(len + sizeof(struct frhdr));
+		if (skb == NULL) 
+		{
+			printk(KERN_NOTICE "%s: Memory squeeze, dropping packet.\n", dev->name);
+			flp->stats.rx_dropped++; 
+			success = 0;
+		}
+		else
+			skb_reserve(skb, sizeof(struct frhdr));
+	}
+
+	/* pick up the data */
+	switch (flp->type)
+	{
+		case SDLA_S502A:
+		case SDLA_S502E:
+			if (success)
+				sdla_read(dev, SDLA_502_RCV_BUF + SDLA_502_DATA_OFS, skb_put(skb,len), len);
+
+			SDLA_WINDOW(dev, SDLA_502_RCV_BUF);
+			cmd->opp_flag = 0;
+			break;
+
+		case SDLA_S508:
+			if (success)
+			{
+				/* is this buffer split off the end of the internal ring buffer */
+				split = addr + len > buf_top + 1 ? len - (buf_top - addr + 1) : 0;
+				len2 = len - split;
+
+				sdla_read(dev, addr, skb_put(skb, len2), len2);
+				if (split)
+					sdla_read(dev, buf_base, skb_put(skb, split), split);
+			}
+
+			/* increment the buffer we're looking at */
+			SDLA_WINDOW(dev, SDLA_508_RXBUF_INFO);
+			flp->buffer = (flp->buffer + 1) % pbufi->rse_num;
+			pbuf->opp_flag = 0;
+			break;
+	}
+
+	if (success)
+	{
+		flp->stats.rx_packets++;
+		dlp = master->priv;
+		(*dlp->receive)(skb, master);
+	}
 
-   restore_flags(flags);
+	restore_flags(flags);
 }
 
 static void sdla_isr(int irq, void *dev_id, struct pt_regs * regs)
 {
-   struct device     *dev;
-   struct frad_local *flp;
-   char              byte;
-
-   dev = irq2dev_map[irq];
-
-   if (dev == NULL)
-   {
-      printk(KERN_WARNING "sdla_isr(): irq %d for unknown device.\n", irq);
-      return;
-   }
-
-   flp = dev->priv;
-
-   if (!flp->initialized)
-   {
-      printk(KERN_WARNING "%s: irq %d for uninitialized device.\n", dev->name, irq);
-      return;
-   }
-
-   dev->interrupt = 1;
-   byte = sdla_byte(dev, flp->type == SDLA_S508 ? SDLA_508_IRQ_INTERFACE : SDLA_502_IRQ_INTERFACE);
-   switch (byte)
-   {
-      case SDLA_INTR_RX:
-         sdla_receive(dev);
-         break;
-
-      /* the command will get an error return, which is processed above */
-      case SDLA_INTR_MODEM:
-      case SDLA_INTR_STATUS:
-         sdla_cmd(dev, SDLA_READ_DLC_STATUS, 0, 0, NULL, 0, NULL, NULL);
-         break;
-
-      case SDLA_INTR_TX:
-      case SDLA_INTR_COMPLETE:
-      case SDLA_INTR_TIMER:
-         printk(KERN_WARNING "%s: invalid irq flag 0x%02X.\n", dev->name, byte);
-         break;
-   }
-
-   /* the S502E requires a manual acknowledgement of the interrupt */ 
-   if (flp->type == SDLA_S502E)
-   {
-      flp->state &= ~SDLA_S502E_INTACK;
-      outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-      flp->state |= SDLA_S502E_INTACK;
-      outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-   }
-
-   /* this clears the byte, informing the Z80 we're done */
-   byte = 0;
-   sdla_write(dev, flp->type == SDLA_S508 ? SDLA_508_IRQ_INTERFACE : SDLA_502_IRQ_INTERFACE, &byte, sizeof(byte));
-   dev->interrupt = 0;
+	struct device     *dev;
+	struct frad_local *flp;
+	char              byte;
+
+	dev = irq2dev_map[irq];
+
+	if (dev == NULL)
+	{
+		printk(KERN_WARNING "sdla_isr(): irq %d for unknown device.\n", irq);
+		return;
+	}
+
+	flp = dev->priv;
+
+	if (!flp->initialized)
+	{
+		printk(KERN_WARNING "%s: irq %d for uninitialized device.\n", dev->name, irq);
+		return;
+	}
+
+	dev->interrupt = 1;
+	byte = sdla_byte(dev, flp->type == SDLA_S508 ? SDLA_508_IRQ_INTERFACE : SDLA_502_IRQ_INTERFACE);
+	switch (byte)
+	{
+		case SDLA_INTR_RX:
+			sdla_receive(dev);
+			break;
+
+		/* the command will get an error return, which is processed above */
+		case SDLA_INTR_MODEM:
+		case SDLA_INTR_STATUS:
+			sdla_cmd(dev, SDLA_READ_DLC_STATUS, 0, 0, NULL, 0, NULL, NULL);
+			break;
+
+		case SDLA_INTR_TX:
+		case SDLA_INTR_COMPLETE:
+		case SDLA_INTR_TIMER:
+			printk(KERN_WARNING "%s: invalid irq flag 0x%02X.\n", dev->name, byte);
+			break;
+	}
+
+	/* the S502E requires a manual acknowledgement of the interrupt */ 
+	if (flp->type == SDLA_S502E)
+	{
+		flp->state &= ~SDLA_S502E_INTACK;
+		outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+		flp->state |= SDLA_S502E_INTACK;
+		outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+	}
+
+	/* this clears the byte, informing the Z80 we're done */
+	byte = 0;
+	sdla_write(dev, flp->type == SDLA_S508 ? SDLA_508_IRQ_INTERFACE : SDLA_502_IRQ_INTERFACE, &byte, sizeof(byte));
+	dev->interrupt = 0;
 }
 
 static void sdla_poll(unsigned long device)
 {
-   struct device     *dev;
-   struct frad_local *flp;
+	struct device	  *dev;
+	struct frad_local *flp;
 
-   dev = (struct device *) device;
-   flp = dev->priv;
+	dev = (struct device *) device;
+	flp = dev->priv;
 
-   if (sdla_byte(dev, SDLA_502_RCV_BUF))
-      sdla_receive(dev);
+	if (sdla_byte(dev, SDLA_502_RCV_BUF))
+		sdla_receive(dev);
 
-   flp->timer.expires = 1;
-   add_timer(&flp->timer);
+	flp->timer.expires = 1;
+	add_timer(&flp->timer);
 }
 
 static int sdla_close(struct device *dev)
 {
-   struct frad_local *flp;
-   struct intr_info  intr;
-   int               len, i;
-   short             dlcis[CONFIG_DLCI_MAX];
-
-   flp = dev->priv;
-
-   len = 0;
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->dlci[i])
-         dlcis[len++] = abs(flp->dlci[i]);
-   len *= 2;
-
-   if (flp->config.station == FRAD_STATION_NODE)
-   {
-      for(i=0;i<CONFIG_DLCI_MAX;i++)
-         if (flp->dlci[i] > 0) 
-            sdla_cmd(dev, SDLA_DEACTIVATE_DLCI, 0, 0, dlcis, len, NULL, NULL);
-      sdla_cmd(dev, SDLA_DELETE_DLCI, 0, 0, &flp->dlci[i], sizeof(flp->dlci[i]), NULL, NULL);
-   }
-
-   memset(&intr, 0, sizeof(intr));
-   /* let's start up the reception */
-   switch(flp->type)
-   {
-      case SDLA_S502A:
-         del_timer(&flp->timer); 
-         break;
-
-      case SDLA_S502E:
-         sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(char) + sizeof(short), NULL, NULL);
-         flp->state &= ~SDLA_S502E_INTACK;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-
-      case SDLA_S507:
-         break;
-
-      case SDLA_S508:
-         sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(struct intr_info), NULL, NULL);
-         flp->state &= ~SDLA_S508_INTEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         break;
-   }
+	struct frad_local *flp;
+	struct intr_info  intr;
+	int               len, i;
+	short             dlcis[CONFIG_DLCI_MAX];
+
+	flp = dev->priv;
+
+	len = 0;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->dlci[i])
+			dlcis[len++] = abs(flp->dlci[i]);
+	len *= 2;
+
+	if (flp->config.station == FRAD_STATION_NODE)
+	{
+		for(i=0;i<CONFIG_DLCI_MAX;i++)
+			if (flp->dlci[i] > 0) 
+				sdla_cmd(dev, SDLA_DEACTIVATE_DLCI, 0, 0, dlcis, len, NULL, NULL);
+		sdla_cmd(dev, SDLA_DELETE_DLCI, 0, 0, &flp->dlci[i], sizeof(flp->dlci[i]), NULL, NULL);
+	}
+
+	memset(&intr, 0, sizeof(intr));
+	/* let's start up the reception */
+	switch(flp->type)
+	{
+		case SDLA_S502A:
+			del_timer(&flp->timer); 
+			break;
+
+		case SDLA_S502E:
+			sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(char) + sizeof(short), NULL, NULL);
+			flp->state &= ~SDLA_S502E_INTACK;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+
+		case SDLA_S507:
+			break;
+
+		case SDLA_S508:
+			sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(struct intr_info), NULL, NULL);
+			flp->state &= ~SDLA_S508_INTEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			break;
+	}
 
-   sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
+	sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
 
-   dev->tbusy = 1;
-   dev->start = 0;
+	dev->tbusy = 1;
+	dev->start = 0;
 
-   MOD_DEC_USE_COUNT;
+	MOD_DEC_USE_COUNT;
 
-   return(0);
+	return(0);
 }
 
 struct conf_data {
-   struct frad_conf config;
-   short            dlci[CONFIG_DLCI_MAX];
+	struct frad_conf config;
+	short            dlci[CONFIG_DLCI_MAX];
 };
 
 static int sdla_open(struct device *dev)
 {
-   struct frad_local *flp;
-   struct dlci_local *dlp;
-   struct conf_data  data;
-   struct intr_info  intr;
-   int               len, i;
-   char              byte;
-
-   flp = dev->priv;
-
-   if (!flp->initialized)
-      return(-EPERM);
-
-   if (!flp->configured)
-      return(-EPERM);
-
-   /* time to send in the configuration */
-   len = 0;
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->dlci[i])
-         data.dlci[len++] = abs(flp->dlci[i]);
-   len *= 2;
-
-   memcpy(&data.config, &flp->config, sizeof(struct frad_conf));
-   len += sizeof(struct frad_conf);
-
-   sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
-   sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, 0, 0, &data, len, NULL, NULL);
-
-   if (flp->type == SDLA_S508)
-      flp->buffer = 0;
-
-   sdla_cmd(dev, SDLA_ENABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
-
-   /* let's start up the reception */
-   memset(&intr, 0, sizeof(intr));
-   switch(flp->type)
-   {
-      case SDLA_S502A:
-         flp->timer.expires = 1;
-         add_timer(&flp->timer);
-         break;
-
-      case SDLA_S502E:
-         flp->state |= SDLA_S502E_ENABLE;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         flp->state |= SDLA_S502E_INTACK;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         byte = 0;
-         sdla_write(dev, SDLA_502_IRQ_INTERFACE, &byte, sizeof(byte));
-         intr.flags = SDLA_INTR_RX | SDLA_INTR_STATUS | SDLA_INTR_MODEM;
-         sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(char) + sizeof(short), NULL, NULL);
-         break;
-
-      case SDLA_S507:
-         break;
-
-      case SDLA_S508:
-         flp->state |= SDLA_S508_INTEN;
-         outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
-         byte = 0;
-         sdla_write(dev, SDLA_508_IRQ_INTERFACE, &byte, sizeof(byte));
-         intr.flags = SDLA_INTR_RX | SDLA_INTR_STATUS | SDLA_INTR_MODEM;
-         intr.irq = dev->irq;
-         sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(struct intr_info), NULL, NULL);
-         break;
-   }
-
-   if (flp->config.station == FRAD_STATION_CPE)
-   {
-      byte = SDLA_ICS_STATUS_ENQ;
-      sdla_cmd(dev, SDLA_ISSUE_IN_CHANNEL_SIGNAL, 0, 0, &byte, sizeof(byte), NULL, NULL);
-   }
-   else
-   {
-      sdla_cmd(dev, SDLA_ADD_DLCI, 0, 0, data.dlci, len - sizeof(struct frad_conf), NULL, NULL);
-      for(i=0;i<CONFIG_DLCI_MAX;i++)
-         if (flp->dlci[i] > 0)
-            sdla_cmd(dev, SDLA_ACTIVATE_DLCI, 0, 0, &flp->dlci[i], 2*sizeof(flp->dlci[i]), NULL, NULL);
-   }
-
-   /* configure any specific DLCI settings */
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->dlci[i])
-      {
-         dlp = flp->master[i]->priv;
-         if (dlp->configured)
-            sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0, &dlp->config, sizeof(struct dlci_conf), NULL, NULL);
-      }
-
-   dev->tbusy = 0;
-   dev->interrupt = 0;
-   dev->start = 1;
+	struct frad_local *flp;
+	struct dlci_local *dlp;
+	struct conf_data  data;
+	struct intr_info  intr;
+	int               len, i;
+	char              byte;
+
+	flp = dev->priv;
+
+	if (!flp->initialized)
+		return(-EPERM);
+
+	if (!flp->configured)
+		return(-EPERM);
+
+	/* time to send in the configuration */
+	len = 0;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->dlci[i])
+			data.dlci[len++] = abs(flp->dlci[i]);
+	len *= 2;
+
+	memcpy(&data.config, &flp->config, sizeof(struct frad_conf));
+	len += sizeof(struct frad_conf);
+
+	sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
+	sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, 0, 0, &data, len, NULL, NULL);
+
+	if (flp->type == SDLA_S508)
+		flp->buffer = 0;
+
+	sdla_cmd(dev, SDLA_ENABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
+
+	/* let's start up the reception */
+	memset(&intr, 0, sizeof(intr));
+	switch(flp->type)
+	{
+		case SDLA_S502A:
+			flp->timer.expires = 1;
+			add_timer(&flp->timer);
+			break;
+
+		case SDLA_S502E:
+			flp->state |= SDLA_S502E_ENABLE;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			flp->state |= SDLA_S502E_INTACK;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			byte = 0;
+			sdla_write(dev, SDLA_502_IRQ_INTERFACE, &byte, sizeof(byte));
+			intr.flags = SDLA_INTR_RX | SDLA_INTR_STATUS | SDLA_INTR_MODEM;
+			sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(char) + sizeof(short), NULL, NULL);
+			break;
+
+		case SDLA_S507:
+			break;
+
+		case SDLA_S508:
+			flp->state |= SDLA_S508_INTEN;
+			outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+			byte = 0;
+			sdla_write(dev, SDLA_508_IRQ_INTERFACE, &byte, sizeof(byte));
+			intr.flags = SDLA_INTR_RX | SDLA_INTR_STATUS | SDLA_INTR_MODEM;
+			intr.irq = dev->irq;
+			sdla_cmd(dev, SDLA_SET_IRQ_TRIGGER, 0, 0, &intr, sizeof(struct intr_info), NULL, NULL);
+			break;
+	}
+
+	if (flp->config.station == FRAD_STATION_CPE)
+	{
+		byte = SDLA_ICS_STATUS_ENQ;
+		sdla_cmd(dev, SDLA_ISSUE_IN_CHANNEL_SIGNAL, 0, 0, &byte, sizeof(byte), NULL, NULL);
+	}
+	else
+	{
+		sdla_cmd(dev, SDLA_ADD_DLCI, 0, 0, data.dlci, len - sizeof(struct frad_conf), NULL, NULL);
+		for(i=0;i<CONFIG_DLCI_MAX;i++)
+			if (flp->dlci[i] > 0)
+				sdla_cmd(dev, SDLA_ACTIVATE_DLCI, 0, 0, &flp->dlci[i], 2*sizeof(flp->dlci[i]), NULL, NULL);
+	}
+
+	/* configure any specific DLCI settings */
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->dlci[i])
+		{
+			dlp = flp->master[i]->priv;
+			if (dlp->configured)
+				sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, abs(flp->dlci[i]), 0, &dlp->config, sizeof(struct dlci_conf), NULL, NULL);
+		}
+
+	dev->tbusy = 0;
+	dev->interrupt = 0;
+	dev->start = 1;
 
-   MOD_INC_USE_COUNT;
+	MOD_INC_USE_COUNT;
 
-   return(0);
+	return(0);
 }
 
 static int sdla_config(struct device *dev, struct frad_conf *conf, int get)
 {
-   struct frad_local *flp;
-   struct conf_data  data;
-   int               i, err;
-   short             size;
-
-   if (dev->type == 0xFFFF)
-      return(-EUNATCH);
-
-   flp = dev->priv;
-
-   if (!get)
-   {
-      if (dev->start)
-         return(-EBUSY);
-
-      err = verify_area(VERIFY_READ, conf, sizeof(struct frad_conf));
-      if (err)
-         return(err);
-
-      copy_from_user(&data.config, conf, sizeof(struct frad_conf));
-
-      if (data.config.station & ~FRAD_STATION_NODE)
-         return(-EINVAL);
-
-      if (data.config.flags & ~FRAD_VALID_FLAGS)
-         return(-EINVAL);
-
-      if ((data.config.kbaud < 0) || 
-          ((data.config.kbaud > 128) && (flp->type != SDLA_S508)))
-         return(-EINVAL);
-
-      if (data.config.clocking & ~(FRAD_CLOCK_INT | SDLA_S508_PORT_RS232))
-         return(-EINVAL);
-
-      if ((data.config.mtu < 0) || (data.config.mtu > SDLA_MAX_MTU))
-         return(-EINVAL);
-
-      if ((data.config.T391 < 5) || (data.config.T391 > 30))
-         return(-EINVAL);
-
-      if ((data.config.T392 < 5) || (data.config.T392 > 30))
-         return(-EINVAL);
-
-      if ((data.config.N391 < 1) || (data.config.N391 > 255))
-         return(-EINVAL);
-
-      if ((data.config.N392 < 1) || (data.config.N392 > 10))
-         return(-EINVAL);
-
-      if ((data.config.N393 < 1) || (data.config.N393 > 10))
-         return(-EINVAL);
-
-      memcpy(&flp->config, &data.config, sizeof(struct frad_conf));
-      flp->config.flags |= SDLA_DIRECT_RECV;
-
-      if (flp->type == SDLA_S508)
-         flp->config.flags |= SDLA_TX70_RX30;
-
-      if (dev->mtu != flp->config.mtu)
-      {
-         /* this is required to change the MTU */
-         dev->mtu = flp->config.mtu;
-         for(i=0;i<CONFIG_DLCI_MAX;i++)
-            if (flp->master[i])
-               flp->master[i]->mtu = flp->config.mtu;
-      }
-
-      flp->config.mtu += sizeof(struct frhdr);
-
-      /* off to the races! */
-      if (!flp->configured)
-         sdla_start(dev);
-
-      flp->configured = 1;
-   }
-   else
-   {
-      err = verify_area(VERIFY_WRITE, conf, sizeof(struct frad_conf));
-      if (err)
-         return(err);
-
-      /* no sense reading if the CPU isn't started */
-      if (dev->start)
-      {
-         size = sizeof(data);
-         if (sdla_cmd(dev, SDLA_READ_DLCI_CONFIGURATION, 0, 0, NULL, 0, &data, &size) != SDLA_RET_OK)
-            return(-EIO);
-      }
-      else
-         if (flp->configured)
-            memcpy(&data.config, &flp->config, sizeof(struct frad_conf));
-         else
-            memset(&data.config, 0, sizeof(struct frad_conf));
-
-      memcpy(&flp->config, &data.config, sizeof(struct frad_conf));
-      data.config.flags &= FRAD_VALID_FLAGS;
-      data.config.mtu -= data.config.mtu > sizeof(struct frhdr) ? sizeof(struct frhdr) : data.config.mtu;
-      copy_to_user(conf, &data.config, sizeof(struct frad_conf));
-   }
+	struct frad_local *flp;
+	struct conf_data  data;
+	int               i, err;
+	short             size;
+
+	if (dev->type == 0xFFFF)
+		return(-EUNATCH);
+
+	flp = dev->priv;
+
+	if (!get)
+	{
+		if (dev->start)
+			return(-EBUSY);
+
+		if(copy_from_user(&data.config, conf, sizeof(struct frad_conf)))
+			return -EFAULT;
+
+		if (data.config.station & ~FRAD_STATION_NODE)
+			return(-EINVAL);
+
+		if (data.config.flags & ~FRAD_VALID_FLAGS)
+			return(-EINVAL);
+
+		if ((data.config.kbaud < 0) || 
+			 ((data.config.kbaud > 128) && (flp->type != SDLA_S508)))
+			return(-EINVAL);
+
+		if (data.config.clocking & ~(FRAD_CLOCK_INT | SDLA_S508_PORT_RS232))
+			return(-EINVAL);
+
+		if ((data.config.mtu < 0) || (data.config.mtu > SDLA_MAX_MTU))
+			return(-EINVAL);
+
+		if ((data.config.T391 < 5) || (data.config.T391 > 30))
+			return(-EINVAL);
+
+		if ((data.config.T392 < 5) || (data.config.T392 > 30))
+			return(-EINVAL);
+
+		if ((data.config.N391 < 1) || (data.config.N391 > 255))
+			return(-EINVAL);
+
+		if ((data.config.N392 < 1) || (data.config.N392 > 10))
+			return(-EINVAL);
+
+		if ((data.config.N393 < 1) || (data.config.N393 > 10))
+			return(-EINVAL);
+
+		memcpy(&flp->config, &data.config, sizeof(struct frad_conf));
+		flp->config.flags |= SDLA_DIRECT_RECV;
+
+		if (flp->type == SDLA_S508)
+			flp->config.flags |= SDLA_TX70_RX30;
+
+		if (dev->mtu != flp->config.mtu)
+		{
+			/* this is required to change the MTU */
+			dev->mtu = flp->config.mtu;
+			for(i=0;i<CONFIG_DLCI_MAX;i++)
+				if (flp->master[i])
+					flp->master[i]->mtu = flp->config.mtu;
+		}
+
+		flp->config.mtu += sizeof(struct frhdr);
+
+		/* off to the races! */
+		if (!flp->configured)
+			sdla_start(dev);
+
+		flp->configured = 1;
+	}
+	else
+	{
+		/* no sense reading if the CPU isn't started */
+		if (dev->start)
+		{
+			size = sizeof(data);
+			if (sdla_cmd(dev, SDLA_READ_DLCI_CONFIGURATION, 0, 0, NULL, 0, &data, &size) != SDLA_RET_OK)
+				return(-EIO);
+		}
+		else
+			if (flp->configured)
+				memcpy(&data.config, &flp->config, sizeof(struct frad_conf));
+			else
+				memset(&data.config, 0, sizeof(struct frad_conf));
+
+		memcpy(&flp->config, &data.config, sizeof(struct frad_conf));
+		data.config.flags &= FRAD_VALID_FLAGS;
+		data.config.mtu -= data.config.mtu > sizeof(struct frhdr) ? sizeof(struct frhdr) : data.config.mtu;
+		return copy_to_user(conf, &data.config, sizeof(struct frad_conf))?-EFAULT:0;
+	}
 
-   return(0);
+	return(0);
 }
 
 static int sdla_xfer(struct device *dev, struct sdla_mem *info, int read)
 {
-   struct sdla_mem mem;
-   int    err;
-   char   *temp;
-
-   err = verify_area(VERIFY_READ, info, sizeof(struct sdla_mem));
-   if (err)
-      return(err);
-
-   copy_from_user(&mem, info, sizeof(mem));
-   if (read)
-   {
-      err = verify_area(VERIFY_WRITE, mem.data, mem.len);
-      if (err)
-         return(err);
-
-      temp = kmalloc(mem.len, GFP_KERNEL);
-      if (!temp)
-         return(-ENOMEM);
-      sdla_read(dev, mem.addr, temp, mem.len);
-      copy_to_user(mem.data, temp, mem.len);
-      kfree(temp);
-   }
-   else
-   {
-      err = verify_area(VERIFY_READ, mem.data, mem.len);
-      if (err)
-         return(err);
-
-      temp = kmalloc(mem.len, GFP_KERNEL);
-      if (!temp)
-         return(-ENOMEM);
-      copy_from_user(temp, mem.data, mem.len);
-      sdla_write(dev, mem.addr, temp, mem.len);
-      kfree(temp);
-   }
-   return(0);
+	struct sdla_mem mem;
+	char	*temp;
+
+	if(copy_from_user(&mem, info, sizeof(mem)))
+		return -EFAULT;
+		
+	if (read)
+	{	
+		temp = kmalloc(mem.len, GFP_KERNEL);
+		if (!temp)
+			return(-ENOMEM);
+		sdla_read(dev, mem.addr, temp, mem.len);
+		if(copy_to_user(mem.data, temp, mem.len))
+			return -EFAULT;
+		kfree(temp);
+	}
+	else
+	{
+		temp = kmalloc(mem.len, GFP_KERNEL);
+		if (!temp)
+			return(-ENOMEM);
+		if(copy_from_user(temp, mem.data, mem.len))
+			return -EFAULT;
+		sdla_write(dev, mem.addr, temp, mem.len);
+		kfree(temp);
+	}
+	return(0);
 }
 
 static int sdla_reconfig(struct device *dev)
 {
-   struct frad_local *flp;
-   struct conf_data  data;
-   int               i, len;
-
-   flp = dev->priv;
-
-   len = 0;
-   for(i=0;i<CONFIG_DLCI_MAX;i++)
-      if (flp->dlci[i])
-         data.dlci[len++] = flp->dlci[i];
-   len *= 2;
-
-   memcpy(&data, &flp->config, sizeof(struct frad_conf));
-   len += sizeof(struct frad_conf);
-
-   sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
-   sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, 0, 0, &data, len, NULL, NULL);
-   sdla_cmd(dev, SDLA_ENABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
+	struct frad_local *flp;
+	struct conf_data  data;
+	int               i, len;
+
+	flp = dev->priv;
+
+	len = 0;
+	for(i=0;i<CONFIG_DLCI_MAX;i++)
+		if (flp->dlci[i])
+			data.dlci[len++] = flp->dlci[i];
+	len *= 2;
+
+	memcpy(&data, &flp->config, sizeof(struct frad_conf));
+	len += sizeof(struct frad_conf);
+
+	sdla_cmd(dev, SDLA_DISABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
+	sdla_cmd(dev, SDLA_SET_DLCI_CONFIGURATION, 0, 0, &data, len, NULL, NULL);
+	sdla_cmd(dev, SDLA_ENABLE_COMMUNICATIONS, 0, 0, NULL, 0, NULL, NULL);
 
-   return(0);
+	return(0);
 }
 
 static int sdla_ioctl(struct device *dev, struct ifreq *ifr, int cmd)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
 
-   flp = dev->priv;
+	if(!suser())
+		return -EPERM;
+		
+	flp = dev->priv;
+
+	if (!flp->initialized)
+		return(-EINVAL);
+
+	switch (cmd)
+	{
+		case FRAD_GET_CONF:
+		case FRAD_SET_CONF:
+			return(sdla_config(dev, (struct frad_conf *)ifr->ifr_data, cmd == FRAD_GET_CONF));
+
+		case SDLA_IDENTIFY:
+			ifr->ifr_flags = flp->type;
+			break;
 
-   if (!flp->initialized)
-      return(-EPERM);
-
-   switch (cmd)
-   {
-      case FRAD_GET_CONF:
-      case FRAD_SET_CONF:
-         return(sdla_config(dev, (struct frad_conf *)ifr->ifr_data, cmd == FRAD_GET_CONF));
-
-      case SDLA_IDENTIFY:
-         ifr->ifr_flags = flp->type;
-         break;
-
-      case SDLA_CPUSPEED:
-         return(sdla_cpuspeed(dev, ifr)); 
+		case SDLA_CPUSPEED:
+			return(sdla_cpuspeed(dev, ifr)); 
 
 /* ==========================================================
 NOTE:  This is rather a useless action right now, as the
@@ -1300,391 +1283,396 @@
        FR.  However, Sangoma has modules for a number of
        other protocols in the works.
 ============================================================*/
-      case SDLA_PROTOCOL:
-         if (flp->configured)
-            return(-EALREADY);
-
-         switch (ifr->ifr_flags)
-         {
-            case ARPHRD_FRAD:
-               dev->type = ifr->ifr_flags;
-               dev->family = AF_UNSPEC;
-               break;
-
-            default:
-               return(-ENOPROTOOPT);
-         }
-         break;
-
-      case SDLA_CLEARMEM:
-         sdla_clear(dev);
-         break;
-
-      case SDLA_WRITEMEM:
-      case SDLA_READMEM:
-         return(sdla_xfer(dev, (struct sdla_mem *)ifr->ifr_data, cmd == SDLA_READMEM));
-
-      case SDLA_START:
-         sdla_start(dev);
-         break;
-
-      case SDLA_STOP:
-         sdla_stop(dev);
-         break;
-
-      default:
-         return(-EOPNOTSUPP);
-   }
-   return(0);
+		case SDLA_PROTOCOL:
+			if (flp->configured)
+				return(-EALREADY);
+
+			switch (ifr->ifr_flags)
+			{
+				case ARPHRD_FRAD:
+					dev->type = ifr->ifr_flags;
+					dev->family = AF_UNSPEC;
+					break;
+				default:
+					return(-ENOPROTOOPT);
+			}
+			break;
+
+		case SDLA_CLEARMEM:
+			sdla_clear(dev);
+			break;
+
+		case SDLA_WRITEMEM:
+		case SDLA_READMEM:
+			return(sdla_xfer(dev, (struct sdla_mem *)ifr->ifr_data, cmd == SDLA_READMEM));
+
+		case SDLA_START:
+			sdla_start(dev);
+			break;
+
+		case SDLA_STOP:
+			sdla_stop(dev);
+			break;
+
+		default:
+			return(-EOPNOTSUPP);
+	}
+	return(0);
 }
 
 int sdla_change_mtu(struct device *dev, int new_mtu)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
 
-   flp = dev->priv;
+	flp = dev->priv;
 
-   if (dev->start)
-      return(-EBUSY);
+	if (dev->start)
+		return(-EBUSY);
 
-   /* for now, you can't change the MTU! */
-   return(-EACCES);
+	/* for now, you can't change the MTU! */
+	return(-EOPNOTSUPP);
 }
 
 int sdla_set_config(struct device *dev, struct ifmap *map)
 {
-   struct frad_local *flp;
-   int               i;
-   char              byte;
+	struct frad_local *flp;
+	int               i;
+	char              byte;
 
-   flp = dev->priv;
+	flp = dev->priv;
 
-   if (flp->initialized)
-      return(-EINVAL);
+	if (flp->initialized)
+		return(-EINVAL);
 
-   for(i=0;i < sizeof(valid_port) / sizeof (int) ; i++)
-      if (valid_port[i] == map->base_addr)
-         break;   
+	for(i=0;i < sizeof(valid_port) / sizeof (int) ; i++)
+		if (valid_port[i] == map->base_addr)
+			break;   
 
-   if (i == sizeof(valid_port) / sizeof(int))
-      return(-EINVAL);
+	if (i == sizeof(valid_port) / sizeof(int))
+		return(-EINVAL);
 
-   dev->base_addr = map->base_addr;
-   request_region(dev->base_addr, SDLA_IO_EXTENTS, dev->name);
+	dev->base_addr = map->base_addr;
+	request_region(dev->base_addr, SDLA_IO_EXTENTS, dev->name);
 
-   /* test for card types, S502A, S502E, S507, S508                 */
-   /* these tests shut down the card completely, so clear the state */
-   flp->type = SDLA_UNKNOWN;
-   flp->state = 0;
+	/* test for card types, S502A, S502E, S507, S508                 */
+	/* these tests shut down the card completely, so clear the state */
+	flp->type = SDLA_UNKNOWN;
+	flp->state = 0;
    
-   for(i=1;i<SDLA_IO_EXTENTS;i++)
-      if (inb(dev->base_addr + i) != 0xFF)
-        break;
-
-   if (i == SDLA_IO_EXTENTS)
-   {   
-      outb(SDLA_HALT, dev->base_addr + SDLA_REG_Z80_CONTROL);
-      if ((inb(dev->base_addr + SDLA_S502_STS) & 0x0F) == 0x08)
-      {
-         outb(SDLA_S502E_INTACK, dev->base_addr + SDLA_REG_CONTROL);
-         if ((inb(dev->base_addr + SDLA_S502_STS) & 0x0F) == 0x0C)
-         {
-            outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
-            flp->type = SDLA_S502E;
-         }
-      }
-   }
-
-   if (flp->type == SDLA_UNKNOWN)
-   {
-      for(byte=inb(dev->base_addr),i=0;i<SDLA_IO_EXTENTS;i++)
-         if (inb(dev->base_addr + i) != byte)
-            break;
-
-      if (i == SDLA_IO_EXTENTS)
-      {
-         outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
-         if ((inb(dev->base_addr + SDLA_S502_STS) & 0x7E) == 0x30)
-         {
-            outb(SDLA_S507_ENABLE, dev->base_addr + SDLA_REG_CONTROL);
-            if ((inb(dev->base_addr + SDLA_S502_STS) & 0x7E) == 0x32)
-            {
-               outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
-               flp->type = SDLA_S507;
-            }
-         }
-      }
-   }
-
-   if (flp->type == SDLA_UNKNOWN)
-   {
-      outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
-      if ((inb(dev->base_addr + SDLA_S508_STS) & 0x3F) == 0x00)
-      {
-         outb(SDLA_S508_INTEN, dev->base_addr + SDLA_REG_CONTROL);
-         if ((inb(dev->base_addr + SDLA_S508_STS) & 0x3F) == 0x10)
-         {
-            outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
-            flp->type = SDLA_S508;
-         }
-      }
-   }
-
-   if (flp->type == SDLA_UNKNOWN)
-   {
-      outb(SDLA_S502A_HALT, dev->base_addr + SDLA_REG_CONTROL);
-      if (inb(dev->base_addr + SDLA_S502_STS) == 0x40)
-      {
-         outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
-         if (inb(dev->base_addr + SDLA_S502_STS) == 0x40)
-         {
-            outb(SDLA_S502A_INTEN, dev->base_addr + SDLA_REG_CONTROL);
-            if (inb(dev->base_addr + SDLA_S502_STS) == 0x44)
-            {
-               outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
-               flp->type = SDLA_S502A;
-            }
-         }
-      }
-   }
-
-   if (flp->type == SDLA_UNKNOWN)
-   {
-      printk(KERN_NOTICE "%s: Unknown card type\n", dev->name);
-      return(-ENODEV);
-   }
-
-   switch(dev->base_addr)
-   {
-      case 0x270:
-      case 0x280:
-      case 0x380: 
-      case 0x390:
-         if ((flp->type != SDLA_S508) && (flp->type != SDLA_S507))
-            return(-EINVAL);
-   }
-
-   switch (map->irq)
-   {
-      case 2:
-         if (flp->type != SDLA_S502E)
-            return(-EINVAL);
-         break;
-
-      case 10:
-      case 11:
-      case 12:
-      case 15:
-      case 4:
-         if ((flp->type != SDLA_S508) && (flp->type != SDLA_S507))
-            return(-EINVAL);
-
-      case 3:
-      case 5:
-      case 7:
-         if (flp->type == SDLA_S502A)
-            return(-EINVAL);
-         break;
-
-      default:
-         return(-EINVAL);
-   }
-   dev->irq = map->irq;
-
-   if (request_irq(dev->irq, &sdla_isr, 0, dev->name, NULL)) 
-      return(-EADDRINUSE);
-
-   irq2dev_map[dev->irq] = dev;
-
-   if (flp->type == SDLA_S507)
-   {
-      switch(dev->irq)
-      {
-         case 3:
-            flp->state = SDLA_S507_IRQ3;
-            break;
-         case 4:
-            flp->state = SDLA_S507_IRQ4;
-            break;
-         case 5:
-            flp->state = SDLA_S507_IRQ5;
-            break;
-         case 7:
-            flp->state = SDLA_S507_IRQ7;
-            break;
-         case 10:
-            flp->state = SDLA_S507_IRQ10;
-            break;
-         case 11:
-            flp->state = SDLA_S507_IRQ11;
-            break;
-         case 12:
-            flp->state = SDLA_S507_IRQ12;
-            break;
-         case 15:
-            flp->state = SDLA_S507_IRQ15;
-            break;
-      }
-   }
-
-   for(i=0;i < sizeof(valid_mem) / sizeof (int) ; i++)
-      if (valid_mem[i] == map->mem_start)
-         break;   
-
-   if (i == sizeof(valid_mem) / sizeof(int))
-      return(-EINVAL);
-
-   if ((flp->type == SDLA_S502A) && (((map->mem_start & 0xF000) >> 12) == 0x0E))
-      return(-EINVAL);
-
-   if ((flp->type != SDLA_S507) && ((map->mem_start >> 16) == 0x0B))
-      return(-EINVAL);
-
-   if ((flp->type == SDLA_S507) && ((map->mem_start >> 16) == 0x0D))
-      return(-EINVAL);
-
-   dev->mem_start = map->mem_start;
-   dev->mem_end = dev->mem_start + 0x2000;
-
-   byte = flp->type != SDLA_S508 ? SDLA_8K_WINDOW : 0;
-   byte |= (map->mem_start & 0xF000) >> (12 + (flp->type == SDLA_S508 ? 1 : 0));
-   switch(flp->type)
-   {
-      case SDLA_S502A:
-      case SDLA_S502E:
-         switch (map->mem_start >> 16)
-         {
-            case 0x0A:
-               byte |= SDLA_S502_SEG_A;
-               break;
-            case 0x0C:
-               byte |= SDLA_S502_SEG_C;
-               break;
-            case 0x0D:
-               byte |= SDLA_S502_SEG_D;
-               break;
-            case 0x0E:
-               byte |= SDLA_S502_SEG_E;
-               break;
-         }
-         break;
-      case SDLA_S507:
-         switch (map->mem_start >> 16)
-         {
-            case 0x0A:
-               byte |= SDLA_S507_SEG_A;
-               break;
-            case 0x0B:
-               byte |= SDLA_S507_SEG_B;
-               break;
-            case 0x0C:
-               byte |= SDLA_S507_SEG_C;
-               break;
-            case 0x0E:
-               byte |= SDLA_S507_SEG_E;
-               break;
-         }
-         break;
-      case SDLA_S508:
-         switch (map->mem_start >> 16)
-         {
-            case 0x0A:
-               byte |= SDLA_S508_SEG_A;
-               break;
-            case 0x0C:
-               byte |= SDLA_S508_SEG_C;
-               break;
-            case 0x0D:
-               byte |= SDLA_S508_SEG_D;
-               break;
-            case 0x0E:
-               byte |= SDLA_S508_SEG_E;
-               break;
-         }
-         break;
-   }
-
-   /* set the memory bits, and enable access */
-   outb(byte, dev->base_addr + SDLA_REG_PC_WINDOW);
-   switch(flp->type)
-   {
-      case SDLA_S502E:
-         flp->state = SDLA_S502E_ENABLE;
-         break;
-      case SDLA_S507:
-         flp->state |= SDLA_MEMEN;
-         break;
-      case SDLA_S508:
-         flp->state = SDLA_MEMEN;
-         break;
-   }
-   outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
+	for(i=1;i<SDLA_IO_EXTENTS;i++)
+		if (inb(dev->base_addr + i) != 0xFF)
+			break;
+
+	if (i == SDLA_IO_EXTENTS)
+	{   
+		outb(SDLA_HALT, dev->base_addr + SDLA_REG_Z80_CONTROL);
+		if ((inb(dev->base_addr + SDLA_S502_STS) & 0x0F) == 0x08)
+		{
+			outb(SDLA_S502E_INTACK, dev->base_addr + SDLA_REG_CONTROL);
+			if ((inb(dev->base_addr + SDLA_S502_STS) & 0x0F) == 0x0C)
+			{
+				outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
+				flp->type = SDLA_S502E;
+			}
+		}
+	}
+
+	if (flp->type == SDLA_UNKNOWN)
+	{
+		for(byte=inb(dev->base_addr),i=0;i<SDLA_IO_EXTENTS;i++)
+			if (inb(dev->base_addr + i) != byte)
+				break;
+
+		if (i == SDLA_IO_EXTENTS)
+		{
+			outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
+			if ((inb(dev->base_addr + SDLA_S502_STS) & 0x7E) == 0x30)
+			{
+				outb(SDLA_S507_ENABLE, dev->base_addr + SDLA_REG_CONTROL);
+				if ((inb(dev->base_addr + SDLA_S502_STS) & 0x7E) == 0x32)
+				{
+					outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
+					flp->type = SDLA_S507;
+				}
+			}
+		}
+	}
+
+	if (flp->type == SDLA_UNKNOWN)
+	{
+		outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
+		if ((inb(dev->base_addr + SDLA_S508_STS) & 0x3F) == 0x00)
+		{
+			outb(SDLA_S508_INTEN, dev->base_addr + SDLA_REG_CONTROL);
+			if ((inb(dev->base_addr + SDLA_S508_STS) & 0x3F) == 0x10)
+			{
+				outb(SDLA_HALT, dev->base_addr + SDLA_REG_CONTROL);
+				flp->type = SDLA_S508;
+			}
+		}
+	}
+
+	if (flp->type == SDLA_UNKNOWN)
+	{
+		outb(SDLA_S502A_HALT, dev->base_addr + SDLA_REG_CONTROL);
+		if (inb(dev->base_addr + SDLA_S502_STS) == 0x40)
+		{
+			outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
+			if (inb(dev->base_addr + SDLA_S502_STS) == 0x40)
+			{
+				outb(SDLA_S502A_INTEN, dev->base_addr + SDLA_REG_CONTROL);
+				if (inb(dev->base_addr + SDLA_S502_STS) == 0x44)
+				{
+					outb(SDLA_S502A_START, dev->base_addr + SDLA_REG_CONTROL);
+					flp->type = SDLA_S502A;
+				}
+			}
+		}
+	}
+
+	if (flp->type == SDLA_UNKNOWN)
+	{
+		printk(KERN_NOTICE "%s: Unknown card type\n", dev->name);
+		return(-ENODEV);
+	}
+
+	switch(dev->base_addr)
+	{
+		case 0x270:
+		case 0x280:
+		case 0x380: 
+		case 0x390:
+			if ((flp->type != SDLA_S508) && (flp->type != SDLA_S507))
+				return(-EINVAL);
+	}
+
+	switch (map->irq)
+	{
+		case 2:
+			if (flp->type != SDLA_S502E)
+				return(-EINVAL);
+			break;
+
+		case 10:
+		case 11:
+		case 12:
+		case 15:
+		case 4:
+			if ((flp->type != SDLA_S508) && (flp->type != SDLA_S507))
+				return(-EINVAL);
+
+		case 3:
+		case 5:
+		case 7:
+			if (flp->type == SDLA_S502A)
+				return(-EINVAL);
+			break;
+
+		default:
+			return(-EINVAL);
+	}
+	dev->irq = map->irq;
+
+	if (request_irq(dev->irq, &sdla_isr, 0, dev->name, NULL)) 
+		return(-EAGAIN);
+
+	irq2dev_map[dev->irq] = dev;
+
+	if (flp->type == SDLA_S507)
+	{
+		switch(dev->irq)
+		{
+			case 3:
+				flp->state = SDLA_S507_IRQ3;
+				break;
+			case 4:
+				flp->state = SDLA_S507_IRQ4;
+				break;
+			case 5:
+				flp->state = SDLA_S507_IRQ5;
+				break;
+			case 7:
+				flp->state = SDLA_S507_IRQ7;
+				break;
+			case 10:
+				flp->state = SDLA_S507_IRQ10;
+				break;
+			case 11:
+				flp->state = SDLA_S507_IRQ11;
+				break;
+			case 12:
+				flp->state = SDLA_S507_IRQ12;
+				break;
+			case 15:
+				flp->state = SDLA_S507_IRQ15;
+				break;
+		}
+	}
+
+	for(i=0;i < sizeof(valid_mem) / sizeof (int) ; i++)
+		if (valid_mem[i] == map->mem_start)
+			break;   
+
+	if (i == sizeof(valid_mem) / sizeof(int))
+	/*
+	 *	FIXME:
+	 *	BUG BUG BUG: MUST RELEASE THE IRQ WE ALLOCATED IN
+	 *	ALL THESE CASES
+	 *
+	 */
+		return(-EINVAL);
+
+	if ((flp->type == SDLA_S502A) && (((map->mem_start & 0xF000) >> 12) == 0x0E))
+		return(-EINVAL);
+
+	if ((flp->type != SDLA_S507) && ((map->mem_start >> 16) == 0x0B))
+		return(-EINVAL);
+
+	if ((flp->type == SDLA_S507) && ((map->mem_start >> 16) == 0x0D))
+		return(-EINVAL);
+
+	dev->mem_start = map->mem_start;
+	dev->mem_end = dev->mem_start + 0x2000;
+
+	byte = flp->type != SDLA_S508 ? SDLA_8K_WINDOW : 0;
+	byte |= (map->mem_start & 0xF000) >> (12 + (flp->type == SDLA_S508 ? 1 : 0));
+	switch(flp->type)
+	{
+		case SDLA_S502A:
+		case SDLA_S502E:
+			switch (map->mem_start >> 16)
+			{
+				case 0x0A:
+					byte |= SDLA_S502_SEG_A;
+					break;
+				case 0x0C:
+					byte |= SDLA_S502_SEG_C;
+					break;
+				case 0x0D:
+					byte |= SDLA_S502_SEG_D;
+					break;
+				case 0x0E:
+					byte |= SDLA_S502_SEG_E;
+					break;
+			}
+			break;
+		case SDLA_S507:
+			switch (map->mem_start >> 16)
+			{
+				case 0x0A:
+					byte |= SDLA_S507_SEG_A;
+					break;
+				case 0x0B:
+					byte |= SDLA_S507_SEG_B;
+					break;
+				case 0x0C:
+					byte |= SDLA_S507_SEG_C;
+					break;
+				case 0x0E:
+					byte |= SDLA_S507_SEG_E;
+					break;
+			}
+			break;
+		case SDLA_S508:
+			switch (map->mem_start >> 16)
+			{
+				case 0x0A:
+					byte |= SDLA_S508_SEG_A;
+					break;
+				case 0x0C:
+					byte |= SDLA_S508_SEG_C;
+					break;
+				case 0x0D:
+					byte |= SDLA_S508_SEG_D;
+					break;
+				case 0x0E:
+					byte |= SDLA_S508_SEG_E;
+					break;
+			}
+			break;
+	}
+
+	/* set the memory bits, and enable access */
+	outb(byte, dev->base_addr + SDLA_REG_PC_WINDOW);
+
+	switch(flp->type)
+	{
+		case SDLA_S502E:
+			flp->state = SDLA_S502E_ENABLE;
+			break;
+		case SDLA_S507:
+			flp->state |= SDLA_MEMEN;
+			break;
+		case SDLA_S508:
+			flp->state = SDLA_MEMEN;
+			break;
+	}
+	outb(flp->state, dev->base_addr + SDLA_REG_CONTROL);
 
-   flp->initialized = 1;
-   return(0);
+	flp->initialized = 1;
+	return(0);
 }
  
-static struct enet_statistics *sdla_stats(struct device *dev)
+static struct net_device_stats *sdla_stats(struct device *dev)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
+	flp = dev->priv;
 
-   flp = dev->priv;
-
-   return(&flp->stats);
+	return(&flp->stats);
 }
 
 int sdla_init(struct device *dev)
 {
-   struct frad_local *flp;
+	struct frad_local *flp;
 
-   /* allocate the private data structure */
-   flp = kmalloc(sizeof(struct frad_local), GFP_KERNEL);
-   if (!flp)
-      return(-ENOMEM);
-
-   memset(flp, 0, sizeof(struct frad_local));
-   dev->priv = flp;
-
-   dev->flags           = 0;
-   dev->open            = sdla_open;
-   dev->stop            = sdla_close;
-   dev->do_ioctl        = sdla_ioctl;
-   dev->set_config      = sdla_set_config;
-   dev->get_stats       = sdla_stats;
-   dev->hard_start_xmit = sdla_transmit;
-   dev->change_mtu	= sdla_change_mtu;
-
-   dev->type            = 0xFFFF;
-   dev->family          = AF_UNSPEC;
-   dev->pa_alen         = 0;
-   dev->pa_addr         = 0;
-   dev->pa_dstaddr      = 0;
-   dev->pa_brdaddr      = 0;
-   dev->pa_mask         = 0;
-   dev->hard_header_len = 0;
-   dev->addr_len        = 0;
-   dev->mtu             = SDLA_MAX_MTU;
+	/* allocate the private data structure */
+	flp = kmalloc(sizeof(struct frad_local), GFP_KERNEL);
+	if (!flp)
+		return(-ENOMEM);
+
+	memset(flp, 0, sizeof(struct frad_local));
+	dev->priv = flp;
+
+	dev->flags		= 0;
+	dev->open		= sdla_open;
+	dev->stop		= sdla_close;
+	dev->do_ioctl		= sdla_ioctl;
+	dev->set_config		= sdla_set_config;
+	dev->get_stats		= sdla_stats;
+	dev->hard_start_xmit	= sdla_transmit;
+	dev->change_mtu		= sdla_change_mtu;
+
+	dev->type		= 0xFFFF;
+	dev->family		= AF_UNSPEC;
+	dev->pa_alen		= 0;
+	dev->pa_addr		= 0;
+	dev->pa_dstaddr 	= 0;
+	dev->pa_brdaddr		= 0;
+	dev->pa_mask		= 0;
+	dev->hard_header_len = 0;
+	dev->addr_len		= 0;
+	dev->mtu		= SDLA_MAX_MTU;
 
-   dev_init_buffers(dev);
+	dev_init_buffers(dev);
    
-   flp->activate        = sdla_activate;
-   flp->deactivate      = sdla_deactivate;
-   flp->assoc           = sdla_assoc;
-   flp->deassoc         = sdla_deassoc;
-   flp->dlci_conf       = sdla_dlci_conf;
-
-   init_timer(&flp->timer);
-   flp->timer.expires   = 1;
-   flp->timer.data      = (unsigned long) dev;
-   flp->timer.function  = sdla_poll;
+	flp->activate		= sdla_activate;
+	flp->deactivate		= sdla_deactivate;
+	flp->assoc		= sdla_assoc;
+	flp->deassoc		= sdla_deassoc;
+	flp->dlci_conf		= sdla_dlci_conf;
+
+	init_timer(&flp->timer);
+	flp->timer.expires	= 1;
+	flp->timer.data		= (unsigned long) dev;
+	flp->timer.function	= sdla_poll;
 
-   return(0);
+	return(0);
 }
 
 void sdla_setup(void)
 {
-   printk("%s.\n", version);
-   register_frad(devname);
+	printk("%s.\n", version);
+	register_frad(devname);
 }
 
 #ifdef MODULE
@@ -1692,21 +1680,20 @@
 
 int init_module(void)
 {
-   int result;
-
-   sdla_setup();
-   if ((result = register_netdev(&sdla0)) != 0)
-      return result;
+	int result;
 
-   return 0;
+	sdla_setup();
+	if ((result = register_netdev(&sdla0)) != 0)
+		return result;
+	return 0;
 }
 
 void cleanup_module(void)
 {
-   unregister_netdev(&sdla0);
-   if (sdla0.priv)
-      kfree(sdla0.priv);
-   if (sdla0.irq)
-      free_irq(sdla0.irq, NULL);
+	unregister_netdev(&sdla0);
+	if (sdla0.priv)
+		kfree(sdla0.priv);
+	if (sdla0.irq)
+		free_irq(sdla0.irq, NULL);
 }
 #endif /* MODULE */

FUNET's LINUX-ADM group, linux-adm@nic.funet.fi
TCL-scripts by Sam Shen, slshen@lbl.gov