From: Nathan Lynch <nathanl@austin.ibm.com>
In sched_exec, schedstat_inc will dereference a null pointer if no domain
is found with the SD_BALANCE_EXEC flag set. This was exposed during
testing of the previous patches where cpus are temporarily attached to a
dummy domain without SD_BALANCE_EXEC set.
Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/kernel/sched.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/sched.c~fix-schedstats-null-deref-in-sched_exec kernel/sched.c
--- 25/kernel/sched.c~fix-schedstats-null-deref-in-sched_exec 2004-09-08 22:08:47.374591152 -0700
+++ 25-akpm/kernel/sched.c 2004-09-08 22:08:47.381590088 -0700
@@ -1727,8 +1727,8 @@ void sched_exec(void)
if (tmp->flags & SD_BALANCE_EXEC)
sd = tmp;
- schedstat_inc(sd, sbe_attempts);
if (sd) {
+ schedstat_inc(sd, sbe_attempts);
new_cpu = find_idlest_cpu(current, this_cpu, sd);
if (new_cpu != this_cpu) {
schedstat_inc(sd, sbe_pushed);
_