From: Nick Wilson <njw@osdl.org>
nfs_readpage_release() causes an oops while accessing a file with NFS
debugging turned on (echo 32767 > /proc/sys/sunrpc/nfs_debug) and a kernel
built with CONFIG_DEBUG_SLAB.
This patch moves the debugging statement above nfs_release_request() to
avoid accessing freed memory.
Signed-off-by: Nick Wilson <njw@osdl.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
fs/nfs/read.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -puN fs/nfs/read.c~nfs-fix-client-oops-when-debugging-is-on fs/nfs/read.c
--- devel/fs/nfs/read.c~nfs-fix-client-oops-when-debugging-is-on 2005-08-21 23:48:50.000000000 -0700
+++ devel-akpm/fs/nfs/read.c 2005-08-21 23:48:50.000000000 -0700
@@ -184,14 +184,13 @@ static void nfs_readpage_release(struct
{
unlock_page(req->wb_page);
- nfs_clear_request(req);
- nfs_release_request(req);
-
dprintk("NFS: read done (%s/%Ld %d@%Ld)\n",
req->wb_context->dentry->d_inode->i_sb->s_id,
(long long)NFS_FILEID(req->wb_context->dentry->d_inode),
req->wb_bytes,
(long long)req_offset(req));
+ nfs_clear_request(req);
+ nfs_release_request(req);
}
/*
_