From: Mika Kukkonen <mikukkon@gmail.com>
With "-W -Wno-unused -Wno-sign-compare" I get the following compile warning:
CC kernel/workqueue.o
kernel/workqueue.c: In function `workqueue_cpu_callback':
kernel/workqueue.c:504: warning: ordered comparison of pointer with integer zero
On error create_workqueue_thread() returns NULL, not negative pointer, so
following trivial patch suggests itself.
Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
kernel/workqueue.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/workqueue.c~create_workqueue_thread-signedness-fix kernel/workqueue.c
--- devel/kernel/workqueue.c~create_workqueue_thread-signedness-fix 2005-08-21 23:48:35.000000000 -0700
+++ devel-akpm/kernel/workqueue.c 2005-08-21 23:48:35.000000000 -0700
@@ -499,7 +499,7 @@ static int __devinit workqueue_cpu_callb
case CPU_UP_PREPARE:
/* Create a new workqueue thread for it. */
list_for_each_entry(wq, &workqueues, list) {
- if (create_workqueue_thread(wq, hotcpu) < 0) {
+ if (!create_workqueue_thread(wq, hotcpu)) {
printk("workqueue for %i failed\n", hotcpu);
return NOTIFY_BAD;
}
_