From: Eric Van Hensbergen <ericvh@gmail.com>
This part of the patch contains the VFS inode interfaces changes related
to hch's comments.
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
fs/9p/vfs_inode.c | 12 +++---------
1 files changed, 3 insertions(+), 9 deletions(-)
diff -puN fs/9p/vfs_inode.c~v9fs-clean-up-vfs_inode-and-setattr-functions-2 fs/9p/vfs_inode.c
--- devel/fs/9p/vfs_inode.c~v9fs-clean-up-vfs_inode-and-setattr-functions-2 2005-07-14 16:23:45.000000000 -0700
+++ devel-akpm/fs/9p/vfs_inode.c 2005-07-14 16:23:45.000000000 -0700
@@ -663,7 +663,7 @@ v9fs_vfs_rename(struct inode *old_dir, s
dprintk(DEBUG_VFS, "\n");
- if(!mistat)
+ if (!mistat)
return -ENOMEM;
if ((!oldfid) || (!olddirfid) || (!newdirfid)) {
@@ -925,21 +925,15 @@ v9fs_vfs_symlink(struct inode *dir, stru
int retval = -EPERM;
struct v9fs_fid *newfid;
struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);
- struct super_block *sb = dir ? dir->i_sb : NULL;
struct v9fs_fcall *fcall = NULL;
struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
dprintk(DEBUG_VFS, " %lu,%s,%s\n", dir->i_ino, dentry->d_name.name,
symname);
- if(!mistat)
+ if (!mistat)
return -ENOMEM;
- if ((!dentry) || (!sb) || (!v9ses)) {
- dprintk(DEBUG_ERROR, "problem with arguments\n");
- return -EBADF;
- }
-
if (!v9ses->extended) {
dprintk(DEBUG_ERROR, "not extended\n");
goto FreeFcall;
@@ -1217,7 +1211,7 @@ v9fs_vfs_mknod(struct inode *dir, struct
dprintk(DEBUG_VFS, " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", dir->i_ino,
dentry->d_name.name, mode, MAJOR(rdev), MINOR(rdev));
- if(!mistat)
+ if (!mistat)
return -ENOMEM;
if (!new_valid_dev(rdev)) {
_