From foo@baz Tue Apr 9 12:12:43 2002
To: Greg KH <gregkh@suse.de>
Date: 25 Mar 2005 15:52:00 -08:00
From: gregkh@suse.de
Subject: [scsi] use device_for_each_child() to properly access child devices.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/scsi/scsi_transport_spi.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
--- gregkh-2.6.orig/drivers/scsi/scsi_transport_spi.c 2005-05-09 16:27:02.000000000 -0700
+++ gregkh-2.6/drivers/scsi/scsi_transport_spi.c 2005-05-09 16:34:09.000000000 -0700
@@ -283,17 +283,21 @@
spi_transport_rd_attr(rti, "%d\n");
spi_transport_rd_attr(pcomp_en, "%d\n");
+/* we only care about the first child device so we return 1 */
+static int child_iter(struct device *dev, void *data)
+{
+ struct scsi_device *sdev = to_scsi_device(dev);
+
+ spi_dv_device(sdev);
+ return 1;
+}
+
static ssize_t
store_spi_revalidate(struct class_device *cdev, const char *buf, size_t count)
{
struct scsi_target *starget = transport_class_to_starget(cdev);
- /* FIXME: we're relying on an awful lot of device internals
- * here. We really need a function to get the first available
- * child */
- struct device *dev = container_of(starget->dev.children.next, struct device, node);
- struct scsi_device *sdev = to_scsi_device(dev);
- spi_dv_device(sdev);
+ device_for_each_child(&starget->dev, NULL, child_iter);
return count;
}
static CLASS_DEVICE_ATTR(revalidate, S_IWUSR, NULL, store_spi_revalidate);